-
Notifications
You must be signed in to change notification settings - Fork 223
Move to expect from package:matcher
#1969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Remove the dependency on `matcher` from `test_api` and `test_core`. - Re-export from `package:matcher/expect.dart` directly to maintain the same library surface from `package:test/test.dart` and `package:test/expect.dart`. - Delete the `test_api` definition of the code that moved to `package:matcher`. - Remove some documentation about specific matchers from the README. Temporarily add dependency overrides on `matcher` while it is unpublished.
Remove tests for imports in removed libraries.
|
I'm going to rework this - we'll keep exporting the APIs from It looks like there are a bunch of other misuses of |
Will make it easier to incrementally roll to flutter
The implementation of `expect` used to be hidden, do the same with `matcher`.
Some internal targets make this a hard failure :(
|
This passed a presubmit, and I'm waiting on a global test run now. It should be possible to land in this state and start prepping for publish. We will necessarily have to publish one of After publishing, I will work on cleaning up usage from |
| 'Please use package:test.') | ||
| library test_core; | ||
|
|
||
| export 'package:test_api/expect.dart'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't find anything internally that was using this import for any of these APIs.
|
I think a short-term cycle is fine. 🤷 |
|
As long as it isn't a library cycle I have no issue with a pub package cycle |
This section was removed in #1969
test_apicopy of theexpectlibraries and tests.package:matcher/expect.dartfromtest_api.package:matcher/expect.dartdirectly to maintain thesame library surface from
package:test/test.dartandpackage:test/expect.dart.lib/srclibraries that are used in libraries that we can'troll synchronously with this package.
Temporarily add dependency overrides on
matcherwhile it isunpublished.