Skip to content

Conversation

@natebosch
Copy link
Member

@natebosch natebosch commented Jun 18, 2020

Fixes #1278

Copy the _loopback code from package:multi_server_socket but model
it as a List<ServerSocket> instead of a single server. Remove the
unnecessary arguments for handling anything other than port 0.

Use a finally block to ensure the socket servers are always closed.

Fixes #1278

Copy the `_loopback` code from `package:multi_server_socket` but model
it as a `List<ServerSocket>` instead of a single server. Remove the
unnecessary arguments for handling anything other than port 0.
@natebosch natebosch requested a review from grouma June 18, 2020 22:29
If there is no exception and we never close the servers they can hold
the process open.

I'm not sure if this fully explains the flakiness on travis...
@natebosch
Copy link
Member Author

It looks like the error is hidden from us when it happens by

// However, users don't think of load tests as "tests", so the error isn't
// helpful for them.
if (liveTest.suite.isLoadSuite) return;

I can't figure out why an error swallowed there ends up making the runner hang on Travis though, but it does seem to do that.

@natebosch natebosch merged commit af633ba into master Jun 19, 2020
@natebosch natebosch deleted the restore-ipv4-node branch June 19, 2020 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node tests fail on macOS

5 participants