Migration: test "add hint" functionality, and fix a path problem on Windows

Change-Id: I6373a20ef3e3e74c77c4a1b9108317996256b831
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146820
Reviewed-by: Samuel Rawlins <[email protected]>
Commit-Queue: Paul Berry <[email protected]>

Author: stereotype441

pkg/nnbd_migration/lib/src/front_end/path_mapper.dart

@@ -27,6 +27,6 @@ class PathMapper {
 
   /// Returns the local filesystem path corresponding to the given [uri].
   String reverseMap(Uri uri) {
-    return provider.pathContext.fromUri(uri);
+    return provider.pathContext.fromUri(uri.replace(scheme: 'file'));
   }
 }

pkg/nnbd_migration/lib/src/preview/preview_site.dart

@@ -240,7 +240,7 @@ class PreviewSite extends Site
     // Update the code on disk.
     //
     var params = uri.queryParameters;
-    var path = Uri.parse(uri.path).toFilePath();
+    var path = pathMapper.reverseMap(uri);
     var offset = int.parse(params['offset']);
     var end = int.parse(params['end']);
     var replacement = params['replacement'];

pkg/nnbd_migration/test/migration_cli_test.dart

@@ -79,6 +79,21 @@ mixin _MigrationCliTestMethods on _MigrationCliTestBase {
     return stderrText;
   }
 
+  void assertHttpSuccess(http.Response response) {
+    if (response.statusCode == 500) {
+      try {
+        var decodedResponse = jsonDecode(response.body);
+        print('Exception: ${decodedResponse['exception']}');
+        print('Stack trace:');
+        print(decodedResponse['stackTrace']);
+      } catch (_) {
+        print(response.body);
+      }
+      fail('HTTP request failed');
+    }
+    expect(response.statusCode, 200);
+  }
+
   Future<String> assertParseArgsFailure(List<String> args) async {
     var cli = _createCli();
     await cli.run(args);
@@ -97,7 +112,7 @@ mixin _MigrationCliTestMethods on _MigrationCliTestBase {
 
   Future assertPreviewServerResponsive(String url) async {
     var response = await http.get(url);
-    expect(response.statusCode, 200);
+    assertHttpSuccess(response);
   }
 
   void assertProjectContents(String projectDir, Map<String, String> expected) {
@@ -332,6 +347,35 @@ int? f() => null
     assertProjectContents(projectDir, projectContents);
   }
 
+  test_lifecycle_preview_add_hint() async {
+    var projectContents = simpleProject(sourceText: 'int x;');
+    var projectDir = await createProjectDir(projectContents);
+    var cli = _createCli();
+    await runWithPreviewServer(cli, [projectDir], (url) async {
+      expect(
+          logger.stdoutBuffer.toString(), contains('No analysis issues found'));
+      await assertPreviewServerResponsive(url);
+      var uri = Uri.parse(url);
+      var authToken = uri.queryParameters['authToken'];
+      var response = await http.post(
+          uri.replace(
+              path: resourceProvider.pathContext
+                  .toUri(resourceProvider.pathContext
+                      .join(projectDir, 'lib', 'test.dart'))
+                  .path,
+              queryParameters: {
+                'offset': '3',
+                'end': '3',
+                'replacement': '/*!*/',
+                'authToken': authToken
+              }),
+          headers: {'Content-Type': 'application/json; charset=UTF-8'});
+      assertHttpSuccess(response);
+      assertProjectContents(
+          projectDir, simpleProject(sourceText: 'int/*!*/ x;'));
+    });
+  }
+
   test_lifecycle_preview_extra_forward_slash() async {
     var projectDir = await createProjectDir(simpleProject());
     var cli = _createCli();