Skip to content

Commit 8636312

Browse files
stereotype441commit-bot@chromium.org
authored andcommitted
Migration: turn off removeViaComments by default.
This was the original behavior, and it persists in some tests because it's more trouble than it's worth to rewrite them. But it's not the behavior we want to ship to users. Change-Id: Ibf1df628f62b01e934d05336bfe43a5a61268f93 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147042 Reviewed-by: Samuel Rawlins <[email protected]> Commit-Queue: Paul Berry <[email protected]>
1 parent 9e5dbad commit 8636312

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

pkg/nnbd_migration/lib/src/fix_aggregator.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ class FixAggregator extends UnifyingAstVisitor<void> {
177177
/// Runs the [FixAggregator] on a [unit] and returns the resulting edits.
178178
static Map<int, List<AtomicEdit>> run(
179179
CompilationUnit unit, String sourceText, Map<AstNode, NodeChange> changes,
180-
{bool removeViaComments = true, bool warnOnWeakCode = false}) {
180+
{bool removeViaComments = false, bool warnOnWeakCode = false}) {
181181
var planner = EditPlanner(unit.lineInfo, sourceText,
182182
removeViaComments: removeViaComments);
183183
var aggregator =

pkg/nnbd_migration/lib/src/nullability_migration_impl.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ class NullabilityMigrationImpl implements NullabilityMigration {
7272
NullabilityMigrationImpl(NullabilityMigrationListener listener,
7373
{bool permissive: false,
7474
NullabilityMigrationInstrumentation instrumentation,
75-
bool removeViaComments = true,
75+
bool removeViaComments = false,
7676
bool warnOnWeakCode = true})
7777
: this._(listener, NullabilityGraph(instrumentation: instrumentation),
7878
permissive, instrumentation, removeViaComments, warnOnWeakCode);

0 commit comments

Comments
 (0)