outdated support for workspaces
#4251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfj
approved these changes
Apr 29, 2024
Comment on lines
+1106
to
+1124
| /// Whether the package [name] is overridden anywhere in the workspace rooted at | ||
| /// [workspaceRoot]. | ||
| bool hasOverride(Package workspaceRoot, String name) { | ||
| return workspaceRoot.allOverridesInWorkspace.containsKey(name); | ||
| } | ||
|
|
||
| /// Whether the package [name] is depended on directly anywhere in the workspace | ||
| /// rooted at [workspaceRoot]. | ||
| bool hasDependency(Package workspaceRoot, String name) { | ||
| return workspaceRoot.transitiveWorkspace | ||
| .any((p) => p.dependencies.containsKey(name)); | ||
| } | ||
|
|
||
| /// Whether the package [name] is dev-depended on directly anywhere in the workspace | ||
| /// rooted at [workspaceRoot]. | ||
| bool hasDevDependency(Package workspaceRoot, String name) { | ||
| return workspaceRoot.transitiveWorkspace | ||
| .any((p) => p.devDependencies.containsKey(name)); | ||
| } |
There was a problem hiding this comment.
nit: these would be neat as extension methods?
There was a problem hiding this comment.
I think I'll refactor these in a follow-up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4250