Move screenshot-related utilities to a separate package. #8951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isoos
force-pushed
the
screenshot-refactor
branch
from
983507e to
dc12a49
Compare
sigurdm
reviewed
Sep 11, 2025
| @@ -4,8 +4,8 @@ | |||
| import 'dart:async'; | |||
|
|
|||
| import 'package:puppeteer/puppeteer.dart'; | |||
| import 'package:screenshot_tools/screenshot_utils.dart'; | |||
There was a problem hiding this comment.
nit: Should we change the name of the main library to align with the package name?
Suggested change
| import 'package:screenshot_tools/screenshot_utils.dart'; | |
| import 'package:screenshot_tools/screenshot_tools.dart'; |
There was a problem hiding this comment.
I'll do the library name changes in a follow-up, after more changes has been done, e.g. the dartdoc-related tooling is also implemented.
sigurdm
reviewed
Sep 11, 2025
| @@ -4,8 +4,8 @@ | |||
| import 'dart:async'; | |||
|
|
|||
| import 'package:puppeteer/puppeteer.dart'; | |||
| import 'package:screenshot_tools/screenshot_utils.dart'; | |||
There was a problem hiding this comment.
And should we have the name of the new package indicate somehow what it is screenshotting?
Something like:
Suggested change
| import 'package:screenshot_tools/screenshot_utils.dart'; | |
| import 'package:browser_screenshots/browser_screenshots.dart'; |
There was a problem hiding this comment.
How about puppeteer_screenshots?
sigurdm
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PUB_prefix from the environment variable, otherwise kept files unchanged.README.md.