Skip to content

Conversation

@dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Apr 7, 2025

Making the test project have a bin/ and test/ file so we can test the dartdev commands.
https://dart-review.googlesource.com/c/sdk/+/420700

(The hook exits with non-0 exit code if the build fails. The assets are not used in the bin and test scripts.)

@github-actions
Copy link

github-actions bot commented Apr 7, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@dcharkes dcharkes merged commit 4928765 into main Apr 7, 2025
34 checks passed
@dcharkes dcharkes deleted the user-defines-tests branch April 7, 2025 11:31
@coveralls
Copy link

Coverage Status

coverage: 84.832%. remained the same
when pulling ce0fbf2 on user-defines-tests
into 3fbbf07 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants