[native_assets_cli] Make nullable fields required in syntax #2121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The syntax
setupmethods remove fields from the underlying json if the values are null. That could lead to accidentally unsetting a value if omitted, which might not be what is expected from the API. (One could expect values not passed are not set.)To keep life consistent, also make the nullable fields for constructors required.
(There were only 2 syntax fields missing in our codebase, see diff. They were doing the right thing, but being explicit is good.)
Inspired by: #2116 (comment)