Skip to content

Conversation

@mosuem
Copy link
Member

@mosuem mosuem commented Jan 2, 2024

See dart-lang/native#873


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@polina-c
Copy link
Contributor

polina-c commented Jan 2, 2024

@devoncarew , can you take a look. I am not experienced enough in this area.

@polina-c polina-c requested a review from devoncarew January 2, 2024 21:46
Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@polina-c
Copy link
Contributor

polina-c commented Jan 2, 2024

@mosuem , can you fix failure of 'Pull Request Labeler / label (pull_request_target)'?
And merge handling of deprecated member from here: #203

@devoncarew
Copy link
Member

The failure for the Pull Request Labeler / label bit won't be fixed until this PR lands. I believe it won't use the new config until it's on master.

@polina-c
Copy link
Contributor

polina-c commented Jan 3, 2024

The failure for the Pull Request Labeler / label bit won't be fixed until this PR lands. I believe it won't use the new config until it's on master.

Ok, merging in spite of failures.

@polina-c polina-c merged commit 3d4c0d6 into main Jan 3, 2024
@polina-c polina-c deleted the fixLabeler branch January 3, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants