Add support for some mmap.h functions #286
Conversation
| @@ -0,0 +1,11 @@ | |||
| // Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file | |||
There was a problem hiding this comment.
I'm not happy with the word "handwritten". I've used "bespoke" before. Should I just use ".g" for generated files and use the obvious name for non-generated code? I thought that would be confusion e.g.
constants.cc
constants.dart
constants.g.cc
constants.g.dart
constants.g.h
constants.h
Or is that better?
There was a problem hiding this comment.
Using .g suffix for auto-generated files and no suffix/prefix for hand-written files looks good to me.
| comment: Locks the processes address space." | ||
| url: "https://pubs.opengroup.org/onlinepubs/9699919799/functions/mlockall.html" | ||
| - prototype: "void *mmap(void *, size_t, int, int, int, off_t)" | ||
| comment: Locks or unlocks the processes address space." |
There was a problem hiding this comment.
"Map pages of memory"
Should we take those comments from documentation / man pages?
| url: "https://pubs.opengroup.org/onlinepubs/9699919799/functions/munlock.html" | ||
| error_value: "-1" | ||
| - prototype: "int munmap(void *, size_t)" | ||
| comment: Locks or unlocks the processes address space." |
| @@ -0,0 +1,11 @@ | |||
| // Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file | |||
There was a problem hiding this comment.
Using .g suffix for auto-generated files and no suffix/prefix for hand-written files looks good to me.
2 participants
Contribution guidelines:
dart format.Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.