Skip to content

Conversation

bryanoltman
Copy link
Contributor

Adds minimal Cloud Tasks support (creating a task with an http request).

I'm not sure if this is built out enough to warrant merging, and I imagine documentation updates would be required as well. lmk what you think!


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.

@bryanoltman bryanoltman requested a review from a team as a code owner October 7, 2025 15:56
Copy link

github-actions bot commented Oct 7, 2025

Package publishing

Package Version Status Publish tag (post-merge)
package:appengine 0.13.11 already published at pub.dev
package:gcloud 0.10.0 ready to publish gcloud-v0.10.0
package:googleapis_firestore_v1 0.1.0-wip WIP (no publish necessary)
package:native_synchronization 0.3.1 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I made a few review comments, but don't have enough context to say whether this is an API we want (or what it should look like).

cc'ing @sigurdm and the @dart-lang/dart-pub-team generally for thoughts.

@@ -0,0 +1,68 @@
/// This library provides a low-level API for accessing Google's Cloud
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the std 3-line copyright header here? For 2025.

@@ -0,0 +1,47 @@
import 'dart:convert';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3-line copyright header

@@ -0,0 +1,65 @@
import 'dart:convert';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyright header

/// If [name] is provided, the task will be given that name.
///
/// Returns a [Future] which completes with the newly created task.
Future<tasks.Task> createTask(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should wrap the Task type in a more opinionated wrapper, such that we don't expose the types from package:googleapis.

Like we do here

class _BucketInfoImpl implements BucketInfo {

@@ -0,0 +1,68 @@
/// This library provides a low-level API for accessing Google's Cloud
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we call the file tasks.dart instead of cloud_tasks.dart (to align with storage.dart etc.)

@@ -1,3 +1,7 @@
## 0.10.0

- Add support for Cloud Tasks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to also update the README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants