Skip to content

[cronet_http] Upgrade cronet-embedded dependency version to support 16 KB page sizes #1824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 30, 2025
Merged

[cronet_http] Upgrade cronet-embedded dependency version to support 16 KB page sizes #1824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1f4758c
Update cronet-embedded dependency version
AlexV525 Sep 25, 2025
88cc199
Update CHANGELOG.md
AlexV525 Sep 25, 2025
8050b75
Update CHANGELOG.md
AlexV525 Sep 26, 2025
a3d41a5
Update pubspec.yaml
AlexV525 Sep 26, 2025
6bcac8d
Update pubspec.yaml
AlexV525 Sep 26, 2025
653a51e
Update CHANGELOG.md
AlexV525 Sep 26, 2025
d7fa0c3
Set minSdkVersion to 23
brianquinlan Sep 29, 2025
06de54d
Indicate if it is using Google Play
brianquinlan Sep 29, 2025
7b509ce
Indicate if we are using Google Play Services in the top-level name
brianquinlan Sep 29, 2025
76419a4
Experiment - does it work on newer SDK versions?
brianquinlan Sep 29, 2025
f4cf972
Try API level 24
brianquinlan Sep 29, 2025
b7a331f
Target minSdkVersion of 24
brianquinlan Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/cronet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ env:

jobs:
verify:
name: Format & Analyze & Test
name: Format & Analyze & Test (${{ matrix.cronetHttpNoPlay == 'true' && 'without Google Play' || 'with Google Play'}})
runs-on: ubuntu-cpu16-ram64
timeout-minutes: 30
strategy:
Expand Down Expand Up @@ -55,7 +55,7 @@ jobs:
echo 'KERNEL=="kvm", GROUP="kvm", MODE="0666", OPTIONS+="static_node=kvm"' | sudo tee /etc/udev/rules.d/99-kvm4all.rules
sudo udevadm control --reload-rules
sudo udevadm trigger --name-match=kvm
- name: Run tests
- name: Run tests (${{ matrix.cronetHttpNoPlay == 'true' && 'without Google Play' || 'with Google Play'}})
uses: reactivecircus/android-emulator-runner@1dcd0090116d15e7c562f8db72807de5e036a4ed
if: always() && steps.install.outcome == 'success'
with:
Expand All @@ -70,7 +70,7 @@ jobs:
# the tests that rely on Google Play services with the newest API
# level (34 as of March 2025). The tests that don't rely on Google
# Play serviecs can test the oldest supported API level.
api-level: ${{ matrix.cronetHttpNoPlay == 'true' && '21' || '29' }}
api-level: ${{ matrix.cronetHttpNoPlay == 'true' && '24' || '29' }}
disable-animations: true
arch: x86_64
target: ${{ matrix.cronetHttpNoPlay == 'true' && 'default' || 'google_apis' }}
Expand Down
6 changes: 6 additions & 0 deletions pkgs/cronet_http/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## 1.6.0-wip

* Upgrade the `cronet-embedded` dependency to `141.7340` version to
support 16 KB page sizes. `cronet-embedded` has target SDK version of 24.
* Change the minimum SDK version to 24.

## 1.5.0

* Add the ability to abort requests.
Expand Down
4 changes: 2 additions & 2 deletions pkgs/cronet_http/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ android {
// - .github/workflows/cronet.yml
// - pkgs/cronet_http/android/build.gradle
// - pkgs/cronet_http/example/android/app/build.gradle
minSdkVersion 21
minSdkVersion 24
}

defaultConfig {
Expand All @@ -64,7 +64,7 @@ android {

dependencies {
if (dartDefines.cronetHttpNoPlay == 'true') {
implementation 'org.chromium.net:cronet-embedded:119.6045.31'
implementation 'org.chromium.net:cronet-embedded:141.7340.3'
} else {
implementation "com.google.android.gms:play-services-cronet:18.1.0"
}
Expand Down
2 changes: 1 addition & 1 deletion pkgs/cronet_http/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ android {
// - .github/workflows/cronet.yml
// - pkgs/cronet_http/android/build.gradle
// - pkgs/cronet_http/example/android/app/build.gradle
minSdkVersion 21
minSdkVersion 24
targetSdkVersion flutter.targetSdkVersion
versionCode flutterVersionCode.toInteger()
versionName flutterVersionName
Expand Down
2 changes: 1 addition & 1 deletion pkgs/cronet_http/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: cronet_http
version: 1.5.0
version: 1.6.0-wip
description: >-
An Android Flutter plugin that provides access to the Cronet HTTP client.
repository: https://github.com/dart-lang/http/tree/master/pkgs/cronet_http
Expand Down
Loading