[cupertino_http]: Switch to ffigen 19.1.0 #1811

brianquinlan · 2025-08-18T23:10:41Z

All tests pass locally. CI fails because of:

I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.
Most changes should add an entry to the changelog and may need to rev the pubspec package version.
Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

github-actions · 2025-08-18T23:11:28Z

Package publishing

Package	Version	Status	Publish tag (post-merge)
package:cronet_http	1.5.0	already published at pub.dev
package:cupertino_http	2.4.0-wip	WIP (no publish necessary)
package:http	1.5.0	already published at pub.dev
package:http2	3.0.0	ready to publish	`http2-v3.0.0`
package:http_multi_server	3.2.2	already published at pub.dev
package:http_parser	4.1.2	already published at pub.dev
package:http_profile	0.1.1-wip	WIP (no publish necessary)
package:ok_http	0.1.1-wip	WIP (no publish necessary)
package:web_socket	1.0.1	already published at pub.dev
package:web_socket_channel	3.0.3	already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

github-actions · 2025-08-18T23:13:00Z

PR Health

Breaking changes

⚠️

Package	Change	Current Version	New Version	Needed Version	Looking good?
cupertino_http	Breaking	2.3.0	2.4.0-wip	3.0.0 Got "2.4.0-wip" expected >= "3.0.0" (breaking changes)	⚠️

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️

Package	Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Coverage

⚠️

File	Coverage
pkgs/cupertino_http/example/integration_test/client_profile_test.dart	💔 Not covered
pkgs/cupertino_http/example/integration_test/http_url_response_test.dart	💔 Not covered
pkgs/cupertino_http/example/integration_test/main.dart	💔 Not covered
pkgs/cupertino_http/example/integration_test/mutable_url_request_test.dart	💔 Not covered
pkgs/cupertino_http/example/integration_test/ns_error_client_exception.dart	💔 Not covered
pkgs/cupertino_http/example/integration_test/url_cache_test.dart	💔 Not covered
pkgs/cupertino_http/example/integration_test/url_request_test.dart	💔 Not covered
pkgs/cupertino_http/example/integration_test/url_response_test.dart	💔 Not covered
pkgs/cupertino_http/example/integration_test/url_session_configuration_test.dart	💔 Not covered
pkgs/cupertino_http/example/integration_test/url_session_delegate_test.dart	💔 Not covered
pkgs/cupertino_http/example/integration_test/url_session_task_test.dart	💔 Not covered
pkgs/cupertino_http/example/integration_test/url_session_test.dart	💔 Not covered
pkgs/cupertino_http/example/integration_test/web_socket_conformance_test.dart	💔 Not covered
pkgs/cupertino_http/example/integration_test/web_socket_test.dart	💔 Not covered
pkgs/cupertino_http/example/lib/book.dart	💔 Not covered
pkgs/cupertino_http/example/lib/main.dart	💔 Not covered
pkgs/cupertino_http/lib/src/cupertino_api.dart	💔 Not covered
pkgs/cupertino_http/lib/src/cupertino_client.dart	💔 Not covered
pkgs/cupertino_http/lib/src/cupertino_web_socket.dart	💔 Not covered
pkgs/cupertino_http/lib/src/native_cupertino_bindings.dart	💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks

⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package	Leaked API symbol	Leaking sources
cupertino_http	ncb.NSURLCache	cupertino_api.dart::URLCache native_cupertino_bindings.dart::NSURLCache::getSharedURLCache native_cupertino_bindings.dart::NSURLCache::setSharedURLCache::value native_cupertino_bindings.dart::NSURLCache::initWithMemoryCapacity native_cupertino_bindings.dart::NSURLCache::initWithMemoryCapacity$1 native_cupertino_bindings.dart::NSURLCache::init native_cupertino_bindings.dart::NSURLCache::new$ native_cupertino_bindings.dart::NSURLCache::allocWithZone native_cupertino_bindings.dart::NSURLCache::alloc native_cupertino_bindings.dart::NSURLCache::self$1 native_cupertino_bindings.dart::NSURLCache::retain native_cupertino_bindings.dart::NSURLCache::autorelease native_cupertino_bindings.dart::NSURLSessionConfiguration::URLCache native_cupertino_bindings.dart::NSURLSessionConfiguration::URLCache
cupertino_http	NSURLRequest	native_cupertino_bindings.dart::NSURLCache::cachedResponseForRequest::request native_cupertino_bindings.dart::NSURLRequest::requestWithURL native_cupertino_bindings.dart::NSURLRequest::requestWithURL$1 native_cupertino_bindings.dart::NSURLRequest::initWithURL native_cupertino_bindings.dart::NSURLRequest::initWithURL$1 native_cupertino_bindings.dart::NSURLRequest::init native_cupertino_bindings.dart::NSURLRequest::new$ native_cupertino_bindings.dart::NSURLRequest::allocWithZone native_cupertino_bindings.dart::NSURLRequest::alloc native_cupertino_bindings.dart::NSURLRequest::self$1 native_cupertino_bindings.dart::NSURLRequest::retain native_cupertino_bindings.dart::NSURLRequest::autorelease native_cupertino_bindings.dart::NSURLRequest::initWithCoder native_cupertino_bindings.dart::NSURLCache::storeCachedResponse::forRequest native_cupertino_bindings.dart::NSURLCache::removeCachedResponseForRequest::request
cupertino_http	NSURLRequestAttribution	native_cupertino_bindings.dart::NSURLRequest::attribution native_cupertino_bindings.dart::NSURLRequestAttribution::NSURLRequestAttributionDeveloper native_cupertino_bindings.dart::NSURLRequestAttribution::NSURLRequestAttributionUser native_cupertino_bindings.dart::NSURLRequestAttribution::values native_cupertino_bindings.dart::NSURLRequestAttribution::fromValue
cupertino_http	NSCachedURLResponse	native_cupertino_bindings.dart::NSURLCache::cachedResponseForRequest native_cupertino_bindings.dart::NSURLCache::storeCachedResponse::cachedResponse
cupertino_http	ncb.NSURLSessionDelegate	cupertino_api.dart::URLSession::delegate
cupertino_http	ncb.NSURLSessionConfiguration	cupertino_api.dart::URLSessionConfiguration native_cupertino_bindings.dart::NSURLSessionConfiguration::getDefaultSessionConfiguration native_cupertino_bindings.dart::NSURLSessionConfiguration::getEphemeralSessionConfiguration native_cupertino_bindings.dart::NSURLSessionConfiguration::backgroundSessionConfigurationWithIdentifier native_cupertino_bindings.dart::NSURLSessionConfiguration::init native_cupertino_bindings.dart::NSURLSessionConfiguration::new$ native_cupertino_bindings.dart::NSURLSessionConfiguration::allocWithZone native_cupertino_bindings.dart::NSURLSessionConfiguration::alloc native_cupertino_bindings.dart::NSURLSessionConfiguration::self$1 native_cupertino_bindings.dart::NSURLSessionConfiguration::retain native_cupertino_bindings.dart::NSURLSessionConfiguration::autorelease
cupertino_http	SSLProtocol	native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMinimumSupportedProtocol native_cupertino_bindings.dart::SSLProtocol::kSSLProtocolUnknown native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol1 native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol11 native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol12 native_cupertino_bindings.dart::SSLProtocol::kDTLSProtocol1 native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol13 native_cupertino_bindings.dart::SSLProtocol::kDTLSProtocol12 native_cupertino_bindings.dart::SSLProtocol::kTLSProtocolMaxSupported native_cupertino_bindings.dart::SSLProtocol::kSSLProtocol2 native_cupertino_bindings.dart::SSLProtocol::kSSLProtocol3 native_cupertino_bindings.dart::SSLProtocol::kSSLProtocol3Only native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol1Only native_cupertino_bindings.dart::SSLProtocol::kSSLProtocolAll native_cupertino_bindings.dart::SSLProtocol::values native_cupertino_bindings.dart::SSLProtocol::fromValue native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMinimumSupportedProtocol native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMaximumSupportedProtocol native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMaximumSupportedProtocol
cupertino_http	tls_protocol_version_t	native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMinimumSupportedProtocolVersion native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_TLSv10 native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_TLSv11 native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_TLSv12 native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_TLSv13 native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_DTLSv10 native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_DTLSv12 native_cupertino_bindings.dart::tls_protocol_version_t::values native_cupertino_bindings.dart::tls_protocol_version_t::fromValue native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMinimumSupportedProtocolVersion native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMaximumSupportedProtocolVersion native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMaximumSupportedProtocolVersion
cupertino_http	NSHTTPCookieStorage	native_cupertino_bindings.dart::NSURLSessionConfiguration::HTTPCookieStorage native_cupertino_bindings.dart::NSURLSessionConfiguration::HTTPCookieStorage
cupertino_http	NSURLCredentialStorage	native_cupertino_bindings.dart::NSURLSessionConfiguration::URLCredentialStorage native_cupertino_bindings.dart::NSURLSessionConfiguration::URLCredentialStorage

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️

// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers

Files
pkgs/http/example/main.dart

This check can be disabled by tagging the PR with skip-license-check.

pkgs/cupertino_http/lib/src/cupertino_api.dart

liamappelbe · 2025-08-28T00:07:18Z

pkgs/cupertino_http/lib/src/cupertino_api.dart

+                );
+                nsRequestCompleter.call(redirectRequest?._nsObject);
+              } catch (e) {
+                // TODO(https://github.com/dart-lang/ffigen/issues/386): Package


This issue is fixed.

Revisions updated by `dart tools/rev_sdk_deps.dart`. ecosystem (https://github.com/dart-lang/ecosystem/compare/68ff911..fd28be2): fd28be2 2025-08-27 Moritz Dont show warnings by default (dart-lang/ecosystem#365) http (https://github.com/dart-lang/http/compare/6656f15..ef05b37): ef05b37 2025-08-27 Brian Quinlan [cupertino_http]: Switch to ffigen 19.1.0 (dart-lang/http#1811) i18n (https://github.com/dart-lang/i18n/compare/6a8f9c7..9a211d1): 9a211d14 2025-08-27 Moritz [package:intl4x] `DateTime` formatting redesign (dart-lang/i18n#1003) protobuf (https://github.com/dart-lang/protobuf/compare/6e9c9f4..765ba8a): 765ba8a 2025-08-28 Ömer Sinan Ağacan Fix non-proto3 JSON format double decoding (google/protobuf.dart#1043) 703bf7c 2025-08-27 Ömer Sinan Ağacan Compile dart2wasm benchmarks with --no-strip-wasm (google/protobuf.dart#1044) 9939965 2025-08-26 Ömer Sinan Ağacan Fix JS interop annotations (google/protobuf.dart#1042) da354a2 2025-08-22 Ömer Sinan Ağacan Update benchmark builder to use -O2 with dart2wasm, add output dir to gitignore (google/protobuf.dart#1041) 41eba19 2025-08-22 Ömer Sinan Ağacan Add sinks to benchmarks to prevent smart tools eliminating benchmarked code (google/protobuf.dart#1040) 3ccc8ab 2025-08-19 dependabot[bot] Bump actions/checkout from 3.5.3 to 4.2.2 (google/protobuf.dart#1036) 6bce9d7 2025-08-19 Ömer Sinan Ağacan Fix unknown enum handling (google/protobuf.dart#853) 19e5a25 2025-08-15 Ömer Sinan Ağacan Implement deepCopy as copying, instead of merge (google/protobuf.dart#742) web (https://github.com/dart-lang/web/compare/ee9733f..e7895bd): e7895bd 2025-08-27 Nikechukwu [interop] Add Support for Declaration Merging and Overloading (dart-lang/web#449) webdev (https://github.com/dart-lang/webdev/compare/9724fea..a7d3d2f): a7d3d2fc 2025-08-27 Ben Konyi [ DWDS ] Fix issue where null was repeatedly sent to connected clients (dart-lang/webdev#2678) e3009dfb 2025-08-27 Nate Biggs Remove stale calls to dartSdkIsAtLeast. (dart-lang/webdev#2677) e0d58082 2025-08-26 Nate Biggs Fix expectation in test accessing private field. (dart-lang/webdev#2676) Change-Id: Ia98a8f065830865f6922ca032939380683645d72 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/447640 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]> Auto-Submit: Devon Carew <[email protected]>

[cupertino_http]: Switch to ffigen 19.1.0

5a957e4

github-actions bot added the package:cupertino_http Issues related to package:cupertino_http label Aug 18, 2025

brianquinlan added 4 commits August 18, 2025 16:20

Fixes

41647e8

Update pubspec.yaml

31520be

Fix

6f3b688

Fix

ee5133d

github-actions bot added the type-infra A repository infrastructure change or enhancement label Aug 18, 2025

brianquinlan added 9 commits August 18, 2025 16:43

Update cupertino.yml

f9df49e

Fix

e3851ea

Update cupertino.yml

cb344ce

Merge remote-tracking branch 'upstream/master' into objective_c_8

3f967e7

Format

1a60235

Fix

2ec9bd6

Update cupertino.yml

a95040b

Update cupertino.yml

03cae66

Update cupertino.yml

5294ae2

brianquinlan requested a review from liamappelbe August 27, 2025 16:56

liamappelbe approved these changes Aug 28, 2025

View reviewed changes

Review fixes

3cb688b

brianquinlan merged commit ef05b37 into dart-lang:master Aug 28, 2025
36 of 42 checks passed

brianquinlan deleted the objective_c_8 branch August 28, 2025 01:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[cupertino_http]: Switch to ffigen 19.1.0 #1811

[cupertino_http]: Switch to ffigen 19.1.0 #1811

Uh oh!

brianquinlan commented Aug 18, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Aug 18, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Aug 18, 2025 •

edited

Loading

Uh oh!

Uh oh!

liamappelbe Aug 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[cupertino_http]: Switch to ffigen 19.1.0 #1811

[cupertino_http]: Switch to ffigen 19.1.0 #1811

Uh oh!

Conversation

brianquinlan commented Aug 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Package publishing

Uh oh!

github-actions bot commented Aug 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Health

Uh oh!

Uh oh!

liamappelbe Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

brianquinlan commented Aug 18, 2025 •

edited

Loading

github-actions bot commented Aug 18, 2025 •

edited

Loading

github-actions bot commented Aug 18, 2025 •

edited

Loading