Skip to content

✨ Introduce ClosableBaseClient #1795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AlexV525
Copy link
Contributor

@AlexV525 AlexV525 commented Jul 19, 2025

When I was trying to write tests against the closed state of clients, I found that all closed states are private. To obtain the closed state without breaking the BaseClient, the PR introduces the ClosableBaseClient specifically for the close interfaces.

No actual functionality changes in this request.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions github-actions bot added package:cupertino_http Issues related to package:cupertino_http package:http package:cronet_http labels Jul 19, 2025
@AlexV525 AlexV525 marked this pull request as ready for review July 19, 2025 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant