Skip to content

Conversation

ueman
Copy link
Contributor

@ueman ueman commented Mar 31, 2025

When copying the UserAgentClient code snippet, the Dart linter immediately complains that the send method is missing the @override annotation. This change fixes that.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

github-actions bot commented Apr 2, 2025

PR Health

Changelog Entry
Package Changed Files
package:http pkgs/http/README.md

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/http/example/main.dart

@mosuem
Copy link
Member

mosuem commented Apr 2, 2025

Seems like the CI is red here - maybe #1432 will fix that. But this is good to go.

@mosuem mosuem merged commit 1cc17f8 into dart-lang:master Apr 2, 2025
30 of 32 checks passed
@ueman ueman deleted the readme-fix branch April 2, 2025 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants