Skip to content

Conversation

@mosuem
Copy link
Member

@mosuem mosuem commented Aug 6, 2025

We run all the checks on all files every time the health workflow file is changed - so far that name was hardcoded. This enables it for other names, such as health_internal.yaml for this repo. The checks in this PR show that it works :)


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions github-actions bot added package:firehose type-infra A repository infrastructure change or enhancement labels Aug 6, 2025
@github-actions
Copy link

github-actions bot commented Aug 6, 2025

Package publishing

Package Version Status Publish tag (post-merge)
package:dart_flutter_team_lints 3.5.2 already published at pub.dev
package:firehose 0.12.0 ready to publish firehose-v0.12.0

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@github-actions
Copy link

github-actions bot commented Aug 6, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
dart_flutter_team_lints None 3.5.2 3.5.2 3.5.2 ✔️
firehose Breaking 0.11.0 0.12.0 0.12.0 ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️
File Coverage
pkgs/dart_flutter_team_lints/tool/dedup.dart 💔 Not covered
pkgs/firehose/lib/firehose.dart 💔 0 % ⬇️ NaN %
pkgs/firehose/lib/src/changelog.dart 💚 100 %
pkgs/firehose/lib/src/delayed_client.dart 💚 23 %
pkgs/firehose/lib/src/github.dart 💚 68 %
pkgs/firehose/lib/src/health/changelog.dart 💚 97 %
pkgs/firehose/lib/src/health/coverage.dart 💚 77 %
pkgs/firehose/lib/src/health/health.dart 💔 94 % ⬇️ 0 %
pkgs/firehose/lib/src/health/lcov.dart 💚 89 %
pkgs/firehose/lib/src/health/license.dart 💚 100 %
pkgs/firehose/lib/src/pub.dart 💚 89 %
pkgs/firehose/lib/src/repo.dart 💚 91 %
pkgs/firehose/lib/src/utils.dart 💚 20 %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

@mosuem mosuem requested a review from dcharkes August 6, 2025 14:14
@mosuem mosuem marked this pull request as ready for review August 6, 2025 14:15
@mosuem mosuem requested a review from devoncarew as a code owner August 6, 2025 14:15
@mosuem mosuem changed the title Make health file name configurab;e Make health file name configurable Aug 6, 2025
required: false
health_yaml_name:
description: The name of the workflow file.
default: '""'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a default here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like below we default to checking for health.yaml or health.yml. Separately, it might be nice to figure out which of those extensions is more common, and only support that (health.yaml?).

@auto-submit auto-submit bot merged commit 68ff911 into main Aug 8, 2025
24 checks passed
@auto-submit auto-submit bot deleted the configureHealthYamlLocation branch August 8, 2025 18:05
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 12, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`.

ai (https://github.com/dart-lang/ai/compare/72a9283..6b4b2bc):
  6b4b2bc  2025-08-11  Greg Spencer  Add ability to filter analyzer results on a set of paths (dart-lang/ai#260)

ecosystem (https://github.com/dart-lang/ecosystem/compare/4543c38..68ff911):
  68ff911  2025-08-08  Moritz  Make health file name configurable (dart-lang/ecosystem#364)

http (https://github.com/dart-lang/http/compare/afda310..6656f15):
  6656f15  2025-08-07  Brian Quinlan  Remove http-beta dependency (dart-lang/http#1806)
  b661894  2025-08-07  Brian Quinlan  Prepare to release packages http/cronet_http/cupertino_http supporting request cancellation (dart-lang/http#1805)

i18n (https://github.com/dart-lang/i18n/compare/25cdb1b..c28ad5e):
  c28ad5ea  2025-08-08  Moritz  Configure gemini (dart-lang/i18n#1002)

web (https://github.com/dart-lang/web/compare/f3c960f..72cdd84):
  72cdd84  2025-08-07  Kevin Moore  Fix pkg:web CI badge (dart-lang/web#441)

Change-Id: I98392b4c4ef037c6ffa8754e8fd2d9a9e17a643e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444781
Reviewed-by: Konstantin Shcheglov <[email protected]>
Auto-Submit: Devon Carew <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit package:firehose skip-do-not-submit-check type-infra A repository infrastructure change or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants