-
Notifications
You must be signed in to change notification settings - Fork 8
Make health file name configurable #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs.
Coverage
|
| File | Coverage |
|---|---|
| pkgs/dart_flutter_team_lints/tool/dedup.dart | 💔 Not covered |
| pkgs/firehose/lib/firehose.dart | 💔 0 % ⬇️ NaN % |
| pkgs/firehose/lib/src/changelog.dart | 💚 100 % |
| pkgs/firehose/lib/src/delayed_client.dart | 💚 23 % |
| pkgs/firehose/lib/src/github.dart | 💚 68 % |
| pkgs/firehose/lib/src/health/changelog.dart | 💚 97 % |
| pkgs/firehose/lib/src/health/coverage.dart | 💚 77 % |
| pkgs/firehose/lib/src/health/health.dart | 💔 94 % ⬇️ 0 % |
| pkgs/firehose/lib/src/health/lcov.dart | 💚 89 % |
| pkgs/firehose/lib/src/health/license.dart | 💚 100 % |
| pkgs/firehose/lib/src/pub.dart | 💚 89 % |
| pkgs/firehose/lib/src/repo.dart | 💚 91 % |
| pkgs/firehose/lib/src/utils.dart | 💚 20 % |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check.
API leaks ✔️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
| Package | Leaked API symbol | Leaking sources |
|---|
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
| Files |
|---|
| no missing headers |
All source files should start with a license header.
| required: false | ||
| health_yaml_name: | ||
| description: The name of the workflow file. | ||
| default: '""' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a default here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like below we default to checking for health.yaml or health.yml. Separately, it might be nice to figure out which of those extensions is more common, and only support that (health.yaml?).
Revisions updated by `dart tools/rev_sdk_deps.dart`. ai (https://github.com/dart-lang/ai/compare/72a9283..6b4b2bc): 6b4b2bc 2025-08-11 Greg Spencer Add ability to filter analyzer results on a set of paths (dart-lang/ai#260) ecosystem (https://github.com/dart-lang/ecosystem/compare/4543c38..68ff911): 68ff911 2025-08-08 Moritz Make health file name configurable (dart-lang/ecosystem#364) http (https://github.com/dart-lang/http/compare/afda310..6656f15): 6656f15 2025-08-07 Brian Quinlan Remove http-beta dependency (dart-lang/http#1806) b661894 2025-08-07 Brian Quinlan Prepare to release packages http/cronet_http/cupertino_http supporting request cancellation (dart-lang/http#1805) i18n (https://github.com/dart-lang/i18n/compare/25cdb1b..c28ad5e): c28ad5ea 2025-08-08 Moritz Configure gemini (dart-lang/i18n#1002) web (https://github.com/dart-lang/web/compare/f3c960f..72cdd84): 72cdd84 2025-08-07 Kevin Moore Fix pkg:web CI badge (dart-lang/web#441) Change-Id: I98392b4c4ef037c6ffa8754e8fd2d9a9e17a643e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444781 Reviewed-by: Konstantin Shcheglov <[email protected]> Auto-Submit: Devon Carew <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]>
We run all the checks on all files every time the health workflow file is changed - so far that name was hardcoded. This enables it for other names, such as
health_internal.yamlfor this repo. The checks in this PR show that it works :)Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.