Skip to content

Conversation

@mosuem
Copy link
Member

@mosuem mosuem commented Dec 6, 2024

...


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@mosuem mosuem requested a review from dcharkes December 6, 2024 12:59
@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Dec 6, 2024
@github-actions
Copy link

github-actions bot commented Dec 6, 2024

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Copy link
Contributor

@dcharkes dcharkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@mosuem mosuem merged commit b4b2a43 into main Dec 6, 2024
13 checks passed
@mosuem mosuem deleted the fixForgotten branch December 6, 2024 13:09
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Dec 9, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`.

core (https://github.com/dart-lang/core/compare/abcf992..7f9f597):
  7f9f597e  2024-12-03  Devon Carew  update the pubspec version of package:collection (dart-lang/core#730)

ecosystem (https://github.com/dart-lang/ecosystem/compare/248b180..b4b2a43):
  b4b2a43  2024-12-06  Moritz  Unsubmit donotsubmit (dart-lang/ecosystem#324)
  8749a2b  2024-12-06  Moritz  Updates to `health.yaml` (dart-lang/ecosystem#310)
  10fb2c0  2024-12-05  Moritz  Ecosystem testing (dart-lang/ecosystem#320)

test (https://github.com/dart-lang/test/compare/2096773..dc0f8ea):
  dc0f8ea4  2024-12-04  Nate Bosch  Fix hang after multiple precompiled browser tests (dart-lang/test#2422)

tools (https://github.com/dart-lang/tools/compare/1c5b8b9..223daf5):
  223daf53  2024-12-05  Ben Konyi  Update `package:vm_service` constraints to >=12.0.0 <16.0.0 (dart-lang/tools#1205)

vector_math (https://github.com/google/vector_math.dart/compare/433fb6c..bd4b574):
  bd4b574  2024-12-09  Plague Fox  Partial fix for benchmarks (google/vector_math.dart#337)

Change-Id: Ie5ce1e95647ac19af1dcfd1d5ee495659052ddc9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399701
Reviewed-by: Nate Bosch <[email protected]>
Commit-Queue: Devon Carew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-infra A repository infrastructure change or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants