Skip to content

Don't write the failure string when skipping #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 10, 2024
Merged

Don't write the failure string when skipping #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0e615f3
Don't write the failure string when skipping
mosuem Jan 9, 2024
7abe832
Fix bash command
mosuem Jan 9, 2024
9118afc
Don't exit with 4
mosuem Jan 9, 2024
d5ec350
Test not checking for changelog
mosuem Jan 9, 2024
c9836e0
Test removing changelog from health defaults
mosuem Jan 9, 2024
fbcb375
Add debug steps
mosuem Jan 9, 2024
292ef71
Switch changelog if clause syntax
mosuem Jan 9, 2024
e2b694a
Fix all
mosuem Jan 9, 2024
b85be58
Revert debug changes
mosuem Jan 9, 2024
a888b5d
Revert "Test removing changelog from health defaults"
mosuem Jan 9, 2024
a32cd03
Remove changelog
mosuem Jan 9, 2024
6e5a3ec
Remove debug change
mosuem Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/health.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ on:

jobs:
version:
if: contains(${{ inputs.checks }}, 'version')
if: ${{ contains(inputs.checks, 'version') }}
uses: ./.github/workflows/health_base.yaml
with:
sdk: ${{ inputs.sdk }}
Expand All @@ -97,7 +97,7 @@ jobs:
use-flutter: ${{ inputs.use-flutter }}

changelog:
if: contains(${{ inputs.checks }}, 'changelog')
if: ${{ contains(inputs.checks, 'changelog') }}
uses: ./.github/workflows/health_base.yaml
with:
sdk: ${{ inputs.sdk }}
Expand All @@ -108,7 +108,7 @@ jobs:
use-flutter: ${{ inputs.use-flutter }}

license:
if: contains(${{ inputs.checks }}, 'license')
if: ${{ contains(inputs.checks, 'license') }}
uses: ./.github/workflows/health_base.yaml
with:
sdk: ${{ inputs.sdk }}
Expand All @@ -119,7 +119,7 @@ jobs:
use-flutter: ${{ inputs.use-flutter }}

coverage:
if: contains(${{ inputs.checks }}, 'coverage')
if: ${{ contains(inputs.checks, 'coverage') }}
uses: ./.github/workflows/health_base.yaml
with:
sdk: ${{ inputs.sdk }}
Expand All @@ -132,7 +132,7 @@ jobs:
use-flutter: ${{ inputs.use-flutter }}

breaking:
if: contains(${{ inputs.checks }}, 'breaking')
if: ${{ contains(inputs.checks, 'breaking') }}
uses: ./.github/workflows/health_base.yaml
with:
sdk: ${{ inputs.sdk }}
Expand All @@ -143,7 +143,7 @@ jobs:
use-flutter: ${{ inputs.use-flutter }}

do-not-submit:
if: contains(${{ inputs.checks }}, 'do-not-submit')
if: ${{ contains(inputs.checks, 'do-not-submit') }}
uses: ./.github/workflows/health_base.yaml
with:
sdk: ${{ inputs.sdk }}
Expand Down
16 changes: 11 additions & 5 deletions .github/workflows/health_base.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,7 @@ jobs:
path: base_repo/
if: ${{ inputs.check == 'coverage' }} || ${{ inputs.check == 'breaking' }}

- name: Write comment if not present
run: |
mkdir -p current_repo/output/
test -f current_repo/output/comment.md || echo $'The ${{ inputs.check }} workflow has encountered an exception and did not complete.' >> current_repo/output/comment.md
- run: mkdir -p current_repo/output/

- uses: subosito/flutter-action@2783a3f08e1baf891508463f8c6653c258246225
if: ${{ inputs.use-flutter }}
Expand Down Expand Up @@ -109,7 +106,16 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
ISSUE_NUMBER: ${{ github.event.number }}
PR_LABELS: "${{ join(github.event.pull_request.labels.*.name) }}"
run: cd current_repo/ && dart pub global run firehose:health --check ${{ inputs.check }} ${{ fromJSON('{"true":"--coverage_web","false":""}')[inputs.coverage_web] }} --fail_on ${{ inputs.fail_on }} --warn_on ${{ inputs.warn_on }}
run: |
cd current_repo/
dart pub global run firehose:health \
--check ${{ inputs.check }} \
${{ fromJSON('{"true":"--coverage_web","false":""}')[inputs.coverage_web] }} \
--fail_on ${{ inputs.fail_on }} \
--warn_on ${{ inputs.warn_on }}

- run: test -f current_repo/output/comment.md || echo $'The ${{ inputs.check }} workflow has encountered an exception and did not complete.' >> current_repo/output/comment.md
if: ${{ '$action_state' == 1 }}

- name: Upload coverage to Coveralls
if: ${{ inputs.upload_coverage }}
Expand Down