-
Notifications
You must be signed in to change notification settings - Fork 130
Canonicalize elements in remote packages #4076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Impl looks good to me.
|
Sorry for the long delay on this one. The tests seem to fail on windows only. Not sure what is going on. @srawlins do you understand why we get this? Is it because the file system on windows is not case-sensitive? |
|
Very strange, the PR is so simple, and the affected test is dartdoc_test.dart, I believe, which is looking at the |
|
Ah this code suspiciously looks at slashes and has the word dartdoc/lib/src/model/package.dart Lines 194 to 196 in 6d5e133
|
Attempt at fixing #4075, flutter/flutter#170868
Before dartdoc would canonicalize Future to dart:async when generating sdk docs, but not when generating a link from package docs.