Skip to content

Conversation

@srawlins
Copy link
Member

Everything in this library is basically library-private: make it so:

  • Privatize config, packageMetaProvider, packageConfigProvider, sdk, embedderSdk, pathContext, processLibrary (and rename to _resolveLibrary), getFiles (and rename to _getFilesToDocument), getEmbedderSdkFiles (and refactor as a getter named _embedderSdkFiles), hasEmbedderSdkFiles. Phew!

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@srawlins srawlins requested a review from kallentu November 13, 2023 18:15
@srawlins srawlins merged commit d4ab3ee into dart-lang:main Nov 13, 2023
@srawlins srawlins deleted the privatize-all-builder branch November 13, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants