Skip to content

Remove cross-export warning #3523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Remove cross-export warning #3523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions lib/src/model/model_element.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,19 +518,6 @@ abstract class ModelElement
(lookup is PropertyAccessorElement ? lookup.variable2 : lookup);
}).toList(growable: true);

// Avoid claiming canonicalization for elements outside of this element's
// defining package.
// TODO(jcollins-g): Make the else block unconditional.
if (candidateLibraries.isNotEmpty &&
!candidateLibraries.any((l) => l.package == definingLibrary.package)) {
warn(PackageWarning.reexportedPrivateApiAcrossPackages,
message: definingLibrary.package.fullyQualifiedName,
referredFrom: candidateLibraries);
} else {
candidateLibraries
.removeWhere((l) => l.package != definingLibrary.package);
}

if (candidateLibraries.isEmpty) {
return null;
}
Expand Down
1 change: 0 additions & 1 deletion lib/src/model/package_graph.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,6 @@ class PackageGraph with CommentReferable, Nameable {
PackageWarning.ambiguousDocReference ||
PackageWarning.ignoredCanonicalFor ||
PackageWarning.packageOrderGivesMissingPackageName ||
PackageWarning.reexportedPrivateApiAcrossPackages ||
PackageWarning.unresolvedDocReference ||
PackageWarning.unknownMacro ||
PackageWarning.unknownHtmlFragment ||
Expand Down
7 changes: 0 additions & 7 deletions lib/src/warnings.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,13 +181,6 @@ enum PackageWarning implements Comparable<PackageWarning> {
'The category-order flag on the command line was given the name of a '
'nonexistent package',
),
reexportedPrivateApiAcrossPackages(
'reexported-private-api-across-packages',
'private API of {0} is reexported by libraries in other packages: ',
shortHelp:
'One or more libraries reexports private API members from outside its '
'own package',
),
unresolvedDocReference(
'unresolved-doc-reference',
'unresolved doc reference [{0}]',
Expand Down