Remove configuration variables for highlights #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #95 Keep the `dart_html_in_strings` variable since it has behavior that can't be changed with highlight groups. Remove the `dart_highlight_types` and `dart_corelib_highlight` variables. The behavior from setting these can be achieved by linking specific highlight groups to `Normal`. Move the lowercase "primitive" type names from `dartCoreType` to `dartSdkClass` since they fit better alongside `String`. The ones remaining in `dartCoreType` are still a "type", or at least often used in a similar way, but have no class definition. When we add `Never` it will be a `dartCoreType`. Add a doc section that describes the highlight groups that are most likely to be configured with an example of how to disable them. Rename some groups from "core" to "sdk" since they are more broad than the `dart:core` library. Use singular names for all highlight groups. Adjust some spacing for better alignment within the syntax file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #95
Keep the
dart_html_in_stringsvariable since it has behavior thatcan't be changed with highlight groups.
Remove the
dart_highlight_typesanddart_corelib_highlightvariables. The behavior from setting these can be achieved by linking
specific highlight groups to
Normal.Move the lowercase "primitive" type names from
dartCoreTypetodartSdkClasssince they fit better alongsideString. The onesremaining in
dartCoreTypeare still a "type", or at least often usedin a similar way, but have no class definition. When we add
Neveritwill be a
dartCoreType.Add a doc section that describes the highlight groups that are most
likely to be configured with an example of how to disable them.
Rename some groups from "core" to "sdk" since they are more broad than
the
dart:corelibrary. Use singular names for all highlight groups.Adjust some spacing for better alignment within the syntax file.