Allow $ character in type names #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `$` as a keyword character since it is allowed in Dart identifiers. This fixes the behavior of the `w` word motion as well as allows syntax groups to match across the character. Refactor the `dartTypeName` regex. Use an optional `_` at the beginning, rather than repeating the pattern with an without `_`. Use the `\u` character class instead of the group `[A-Z]`. Replace the `\w` character class with a group that includes the same characters and adds `$`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
$as a keyword character since it is allowed in Dart identifiers.This fixes the behavior of the
wword motion as well as allows syntaxgroups to match across the character.
Refactor the
dartTypeNameregex. Use an optional_at the beginning,rather than repeating the pattern with an without
_. Use the\ucharacter class instead of the group
[A-Z]. Replace the\wcharacterclass with a group that includes the same characters and adds
$.