Add support for digit separators #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
srawlins
approved these changes
Jul 31, 2024
Member
srawlins
left a comment
srawlins
left a comment
There was a problem hiding this comment.
Looks perfect! Very tidy, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the grammar to allow underscores within numbers (but not as the first digit), using some examples from https://github.com/dart-lang/language/blob/main/working/digit-separators/feature-specification.md#examples as tests.
I committed this in two parts:
This is to make it easier to see the impact of the change to the grammar (by looking at the second changeset) without the whole block being new code.
Note: This change does allow trailing underscores (which are not valid), because that way the colouring will still work out while you're typing a literal with an underscore (you'll ofc still see an analysis error while it's invalid) and it keeps the regex simpler.
@srawlins