#2559. Add extension types and enums to augmenting constructors test. Part 2. #2972
Conversation
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
Looks good! I do have a comment on a couple of situations where the feature specification is open to interpretation. I'm pushing for an error which seems to have been intended all the time. If it gets controversial then we may end up being allowed to do these things, otherwise these tests should expect an error in a few cases where they currently don't.
I think it would make sense to wait a bit for dart-lang/language#4157 because the spec text currently contains hints that there should be an error, but no clear statement to that effect. So we can't really say that "the spec currently says" that we should or shouldn't have those errors.
| augment enum E { | ||
| augment e0; | ||
| augment const E.foo(int x): this.foo(x); | ||
| augment const E.foo(int x): this(x + 1); |
There was a problem hiding this comment.
I think this should be an error, but dart-lang/language#4157 will clarify that.
LanguageFeatures/Augmentation-libraries/augmenting_constructors_A19_t02.dart
Show resolved
Hide resolved
sgrekhov
added
the
status-blocked
|
Thank you. Marked as blocked by dart-lang/language#4157. |
|
Updated according to the dart-lang/language#4157. Please review. |
sgrekhov
removed
the
status-blocked
|
Marge conflics are resolved. Please review. |
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
Looks good, just a couple of nits.
LanguageFeatures/Augmentation-libraries/augmenting_constructors_A18_t03_lib.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Augmentation-libraries/augmenting_constructors_A18_t04.dart
Outdated
Show resolved
Hide resolved
| /// ... | ||
| /// It is a compile-time error if: | ||
| /// - The augmented constructor has any initializers or a body. | ||
| /// - The augmented factory constructor has a body, or it is redirecting. |
There was a problem hiding this comment.
Different from LanguageFeatures/Augmentation-libraries/augmenting_constructors_A18_t05.dart?
There was a problem hiding this comment.
This is an outdated diff. Doublechaked, the actual description is OK, the same as in LanguageFeatures/Augmentation-libraries/augmenting_constructors_A18_t05.dart
LanguageFeatures/Augmentation-libraries/augmenting_constructors_A18_t03_lib.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Augmentation-libraries/augmenting_constructors_A18_t04.dart
Outdated
Show resolved
Hide resolved
2024-11-28 [email protected] dart-lang/co19#2976. Update assertion texts according to the new spec (dart-lang/co19#3000) 2024-11-28 [email protected] dart-lang/co19#2119. Add issue number to other_declarations_A04_t07.dart (dart-lang/co19#3001) 2024-11-28 [email protected] dart-lang/co19#2976. Add semantics tests (dart-lang/co19#2998) 2024-11-27 [email protected] Fixes dart-lang/co19#2996. Update CFE expected errors locations (dart-lang/co19#2999) 2024-11-25 [email protected] dart-lang/co19#2559. Add extension types and enums to augmenting constructors test. Part 2. (dart-lang/co19#2972) 2024-11-25 [email protected] dart-lang/co19#2956. Add more type `void` tests (dart-lang/co19#2997) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try Change-Id: I858dbf6908fe32f38a401ce4ebfe120e064de4aa Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/398160 Reviewed-by: Alexander Thomas <[email protected]> Commit-Queue: Alexander Thomas <[email protected]> Reviewed-by: Erik Ernst <[email protected]>
2 participants
No description provided.