Skip to content

Fixes #1734. Expect a static warning in case of not-necessary null-check/assert #1738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Fixes #1734. Expect a static warning in case of not-necessary null-check/assert #1738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 32 additions & 14 deletions LanguageFeatures/Patterns/list_A05_t05.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
/// var [a, b, ...rest, c, d] = [1, 2, 3, 4, 5, 6, 7];
/// print('$a $b $rest $c $d'); // Prints "1 2 [3, 4, 5] 6 7".
///
/// @description Check that null-check subpattern can be used in a list's rest
/// pattern
/// @description Check that it is a static warning if null-check subpattern is
/// used in a list's rest pattern
/// @author [email protected]

// SharedOptions=--enable-experiment=patterns
Expand All @@ -27,19 +27,37 @@ import "../../Utils/expect.dart";
String test1(List list) {
return switch (list) {
<int>[1, 2, 3, 4, ... var r1?] => r1.toString(),
// ^
// [analyzer] STATIC_WARNING.UNNECESSARY_NULL_CHECK_PATTERN
// [cfe] The null-check pattern will have no effect because the matched type isn't nullable.
[2, ...final r2?, 5, 6] => r2.toString(),
// ^
// [analyzer] STATIC_WARNING.UNNECESSARY_NULL_CHECK_PATTERN
// [cfe] The null-check pattern will have no effect because the matched type isn't nullable.
<int>[.../* comment */ List r3?, 6, 7, 8] => r3.toString(),
// ^
// [analyzer] STATIC_WARNING.UNNECESSARY_NULL_CHECK_PATTERN
// [cfe] The null-check pattern will have no effect because the matched type isn't nullable.
_ => "default"
};
}

String test2(List list) {
switch (list) {
case <int>[1, 2, 3, 4, ... var r1?]:
// ^
// [analyzer] STATIC_WARNING.UNNECESSARY_NULL_CHECK_PATTERN
// [cfe] The null-check pattern will have no effect because the matched type isn't nullable.
return r1.toString();
case [2, ...final r2?, 5, 6]:
// ^
// [analyzer] STATIC_WARNING.UNNECESSARY_NULL_CHECK_PATTERN
// [cfe] The null-check pattern will have no effect because the matched type isn't nullable.
return r2.toString();
case <int>[... /* comment */ List r3?, 6, 7, 8]:
// ^
// [analyzer] STATIC_WARNING.UNNECESSARY_NULL_CHECK_PATTERN
// [cfe] The null-check pattern will have no effect because the matched type isn't nullable.
return r3.toString();
default:
return "default";
Expand All @@ -48,28 +66,28 @@ String test2(List list) {

String test3(List list) {
if (list case <int>[1, 2, 3, 4, ... var r1?]) {
// ^
// [analyzer] STATIC_WARNING.UNNECESSARY_NULL_CHECK_PATTERN
// [cfe] The null-check pattern will have no effect because the matched type isn't nullable.
return r1.toString();
}
if (list case [2, ...final r2?, 5, 6]) {
// ^
// [analyzer] STATIC_WARNING.UNNECESSARY_NULL_CHECK_PATTERN
// [cfe] The null-check pattern will have no effect because the matched type isn't nullable.
return r2.toString();
}
if (list case <int>[... /* comment */ List r3?, 6, 7, 8]) {
// ^
// [analyzer] STATIC_WARNING.UNNECESSARY_NULL_CHECK_PATTERN
// [cfe] The null-check pattern will have no effect because the matched type isn't nullable.
return r3.toString();
}
return "default";
}

main() {
Expect.equals([5, 6].toString(), test1([1, 2, 3, 4, 5, 6]));
Expect.equals([3, 4].toString(), test1([2, 3, 4, 5, 6]));
Expect.equals([3, 4, 5].toString(), test1([3, 4, 5, 6, 7, 8]));
Expect.equals("default", test1([1, 2]));
Expect.equals([5, 6].toString(), test2([1, 2, 3, 4, 5, 6]));
Expect.equals([3, 4].toString(), test2([2, 3, 4, 5, 6]));
Expect.equals([3, 4, 5].toString(), test2([3, 4, 5, 6, 7, 8]));
Expect.equals("default", test2([1, 2]));
Expect.equals([5, 6].toString(), test3([1, 2, 3, 4, 5, 6]));
Expect.equals([3, 4].toString(), test3([2, 3, 4, 5, 6]));
Expect.equals([3, 4, 5].toString(), test3([3, 4, 5, 6, 7, 8]));
Expect.equals("default", test3([1, 2]));
test1([1, 2, 3, 4, 5, 6]);
test2([1, 2, 3, 4, 5, 6]);
test3([1, 2, 3, 4, 5, 6]);
}
2 changes: 1 addition & 1 deletion LanguageFeatures/Patterns/switch_statement_A07_t01.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import "../../Utils/expect.dart";
import "patterns_lib.dart";

String test(Object o) {
String test(Object? o) {
String toReturn = "";
switch (o) {
case 0 || -42:
Expand Down
2 changes: 1 addition & 1 deletion LanguageFeatures/Patterns/switch_statement_A07_t02.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import "../../Utils/expect.dart";
import "patterns_lib.dart";

String test(Object o) {
String test(Object? o) {
String toReturn = "";
switch (o) {
case 0 || -42:
Expand Down