Avoid sender making more progress than the receiver in Isolate/pause_… #1242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…A01_t01/2. In these tests, one isolate continuously sends messages to another without back pressure. If the system is loaded, the sender may send messages at a faster rate then the receiver can process them and the test can time out before receiver processes enough messages to end the test. Instead of processing a large number of messages to ensure some of them would happen after the pause request, use synchronous sleeps.
Contributor
|
Thanx! |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jan 13, 2022
2022-01-12 [email protected] dart-lang/co19#1259. Roll failures fixed 2022-01-12 [email protected] dart-lang/co19#1258. Enhanced Enums semantics tests rewritten according to changed spec 2022-01-12 [email protected] Fixes dart-lang/co19#1261. Expected result value fixed 2022-01-11 [email protected] dart-lang/co19#1259. Different roll failures fixed (mainly typos) 2022-01-11 [email protected] Fixes dart-lang/co19#1247. Allow positional parameters with the different name than in superclass 2022-01-10 [email protected] Fixes dart-lang/co19#1248. Add additional error expectation 2022-01-10 [email protected] Fixes dart-lang/co19#1256. Use correct type of super parameters. Expect an error if the type is wrong 2022-01-10 [email protected] Fixes dart-lang/co19#1255. Use nullable type parameter for type check 2022-01-10 [email protected] Fixes dart-lang/co19#1254. Typo fixed 2022-01-10 [email protected] Fixes dart-lang/co19#1253. Typo fixed 2022-01-10 [email protected] Fixes dart-lang/co19#1252. Typo fixed 2022-01-10 [email protected] Fixes dart-lang/co19#1251. Default value is added to non-nullable optional argument 2022-01-10 [email protected] Fixes dart-lang/co19#1250. Named parameter made named in a constructor call 2022-01-10 [email protected] Fixes dart-lang/co19#1249. Missed superconstructor added 2022-01-10 [email protected] Fixes dart-lang/co19#1246. Use correct type for type inference 2021-12-28 [email protected] Avoid sender making more progress than the receiver in Isolate/pause_A01_t01/2. (dart-lang/co19#1242) 2021-12-28 [email protected] Fixes dart-lang/co19#1243. Runtime type checks added to typed_data tests 2021-12-27 [email protected] dart-lang/co19#1243 Runtime type checks added to io and match tests 2021-12-24 [email protected] dart-lang/co19#1243 Runtime type checks added 2021-12-23 [email protected] dart-lang/co19#1243 Runtime type checks added to Spread collections tests 2021-12-23 [email protected] dart-lang/co19#1243 Runtime type checks moved to Expect class 2021-12-23 [email protected] dart-lang/co19#1243 Runtime type checks added to Set literals tests 2021-12-23 [email protected] dart-lang/co19#1243 Runtime type checks added to Expect class 2021-12-22 [email protected] dart-lang/co19#1243 Runtime type checks added for nnbd tests 2021-12-22 [email protected] dart-lang/co19#1244 CHECK_TOP_MERGE replaced by CheckTopMerge 2021-12-22 [email protected] dart-lang/co19#1243 Runtime type checks added for nnbd tests 2021-12-21 [email protected] Fixes dart-lang/co19#1245. Fix checking type of Enum members 2021-12-20 [email protected] dart-lang/co19#1243 Runtime type checks added for Control flow collections, Constructor tear-offs and Generic functions as type arguments 2021-12-17 [email protected] dart-lang/co19#1243 Runtime checks added for statements which can be optimized to 'true' or 'false' 2021-12-16 [email protected] Issue dart-lang/co19#1244: Utils functions updated according to the Effective Dart Guide, relative tests updated accordingly. 2021-12-16 [email protected] dart-lang/co19#1243 Runtime checks added for statements which can be optimized to 'true' or 'false' 2021-12-15 [email protected] dart-lang/co19#1243 Runtime checks added for statements which can be optimized to 'true' or 'false' 2021-12-15 [email protected] dart-lang/co19#1243 Expect.isTrue() is returned back for type checking 2021-12-14 [email protected] dart-lang/co19#1243 Runtime checks added for statements which can be optimized to 'true' or 'false' 2021-12-13 [email protected] Issue dart-lang/co19#1094: minor improvement for Utils/test_mode_check 2021-12-13 [email protected] dart-lang/co19#1243 Runtime checks added for statements which can be optimized to 'true' or 'false' Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try Change-Id: I8b2b346600c03061b8b735be874c3f377d70b354 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/227800 Reviewed-by: William Hesse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…A01_t01/2.
In these tests, one isolate continuously sends messages to another without back pressure. If the system is loaded, the sender may send messages at a faster rate then the receiver can process them and the test can time out before receiver processes enough messages to end the test. Instead of processing a large number of messages to ensure some of them would happen after the pause request, use synchronous sleeps.