co19/LanguageFeatures/Patterns/switch_statement_A06_t01

[scheglov]

A few issues here.

1. I think we need const before [].
2. I think ...r probably should be ...var r
3. When matching against Record, the type of each field is Object?

FAILED: dart2analyzer-none release_arm64 co19/LanguageFeatures/Patterns/switch_statement_A06_t01
Expected: Pass
Actual: CompileTimeError

--- Command "dart2analyzer" (took 06.000639s):
DART_CONFIGURATION=ReleaseARM64 sdk/bin/dart --packages=.dart_tool/package_config.json pkg/analyzer_cli/bin/analyzer.dart --use-analysis-driver-memory-byte-store --dart-sdk=/Users/scheglov/Source/Dart/sdk.git/sdk/sdk -Dtest_runner.configuration=custom-configuration-1 --enable-experiment=patterns,records --ignore-unrecognized-flags --packages=/Users/scheglov/Source/Dart/sdk.git/sdk/.dart_tool/package_config.json --format=json /Users/scheglov/Source/Dart/sdk.git/sdk/tests/co19/src/LanguageFeatures/Patterns/switch_statement_A06_t01.dart

unexpected analysis errors in switch_statement_A06_t01.dart:
- Line 101, column 20: COMPILE_TIME_ERROR.CONSTANT_PATTERN_WITH_NON_CONSTANT_EXPRESSION
  The expression of a constant pattern must be a valid constant.

- Line 101, column 20: COMPILE_TIME_ERROR.UNDEFINED_IDENTIFIER
  Undefined name 'r'.

- Line 101, column 29: COMPILE_TIME_ERROR.UNDEFINED_IDENTIFIER
  Undefined name 'r'.

- Line 121, column 28: COMPILE_TIME_ERROR.UNCHECKED_USE_OF_NULLABLE_VALUE
  The operator '>' can't be unconditionally invoked because the receiver can be 'null'.

- Line 123, column 30: COMPILE_TIME_ERROR.UNCHECKED_USE_OF_NULLABLE_VALUE
  The operator '<' can't be unconditionally invoked because the receiver can be 'null'.

- Line 125, column 34: COMPILE_TIME_ERROR.UNCHECKED_USE_OF_NULLABLE_VALUE
  The operator '>' can't be unconditionally invoked because the receiver can be 'null'.

- Line 127, column 36: COMPILE_TIME_ERROR.UNCHECKED_USE_OF_NULLABLE_VALUE
  The operator '<' can't be unconditionally invoked because the receiver can be 'null'.

--- Re-run this test:
python3 tools/test.py -m release -c dart2analyzer -a arm64 co19/LanguageFeatures/Patterns/switch_statement_A06_t01

[sgrekhov]

Please see #1723. I don't think that we need const before []. It's a list pattern, we don't need const there