Skip to content

Conversation

@davidmorgan
Copy link
Contributor

@davidmorgan davidmorgan commented Sep 19, 2025

Combine three related classes, FinalizedReader, OptionalOutputTracker and FinalizedAssetsView, into BuildOutputReader.

Make it an output of the build, in BuildResult, instead of passed around separately.

Use the build output from the build result in the daemon and serve commands.

@github-actions
Copy link

PR Health

Changelog Entry
Package Changed Files
package:build_runner build_runner/lib/src/build/build.dart
build_runner/lib/src/build/build_result.dart
build_runner/lib/src/build/build_series.dart
build_runner/lib/src/build/finalized_assets_view.dart
build_runner/lib/src/build_plan/testing_overrides.dart
build_runner/lib/src/commands/daemon/asset_server.dart
build_runner/lib/src/commands/daemon/daemon_builder.dart
build_runner/lib/src/commands/serve/server.dart
build_runner/lib/src/commands/serve_command.dart
build_runner/lib/src/commands/watch/watcher.dart
build_runner/lib/src/commands/watch_command.dart
build_runner/lib/src/io/finalized_reader.dart

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

@davidmorgan davidmorgan force-pushed the finalized-reader-result branch 2 times, most recently from f08f498 to e8abfd6 Compare September 19, 2025 12:52
@davidmorgan davidmorgan changed the title Make FinalizedReader a result Refactor file outputs to BuildOutputReader Sep 19, 2025
@davidmorgan davidmorgan force-pushed the finalized-reader-result branch from e8abfd6 to 020e17d Compare September 19, 2025 13:33
@davidmorgan davidmorgan marked this pull request as ready for review September 19, 2025 13:38
@davidmorgan davidmorgan merged commit ab5c986 into dart-lang:master Sep 22, 2025
32 of 33 checks passed
@davidmorgan davidmorgan deleted the finalized-reader-result branch September 22, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants