Skip to content

perf: optimize Request.read #1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 30, 2025
+6 −8
Merged

perf: optimize Request.read #1410

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
45f32ab
chore: optimize Request.read
kevmoo Jun 22, 2024
cd73d07
Merge branch 'main' into use_expando
tomarra Jun 25, 2024
e433734
Update packages/dart_frog/pubspec.yaml
kevmoo Jun 25, 2024
40c7ed2
Update packages/dart_frog/CHANGELOG.md
kevmoo Jun 25, 2024
3d6c280
Merge branch 'main' into use_expando
Aug 6, 2024
3a962f5
Merge branch 'main' into use_expando
Jan 31, 2025
6634741
Merge branch 'main' into use_expando
felangel Sep 30, 2025
e0f76c9
refactor: minor adjustments
felangel Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions packages/dart_frog/lib/src/request.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ class Request {

Request._(this._request);

shelf.Request _request;
final shelf.Request _request;

/// Connection information for the associated HTTP request.
HttpConnectionInfo get connectionInfo {
Expand Down Expand Up @@ -146,16 +146,12 @@ class Request {

/// Returns a [Future] containing the body as a [String].
Future<String> body() async {
const requestBodyKey = 'dart_frog.request.body';
final bodyFromContext =
_request.context[requestBodyKey] as Completer<String>?;
if (bodyFromContext != null) return bodyFromContext.future;
final bodyFromCache = _requestBodyCache[_request];
if (bodyFromCache != null) return bodyFromCache;

final completer = Completer<String>();
try {
_request = _request.change(
context: {..._request.context, requestBodyKey: completer},
);
_requestBodyCache[_request] = completer.future;
completer.complete(await _request.readAsString());
} catch (error, stackTrace) {
completer.completeError(error, stackTrace);
Expand Down Expand Up @@ -184,3 +180,5 @@ class Request {
return Request._(_request.change(headers: headers, path: path, body: body));
}
}

final _requestBodyCache = Expando<Future<String>>('dart_frog.request.body');