Fixes async gap handling. #84
Conversation
ghost
requested a review
from 
|
RE:CHANGELOG: I assume I'm supposed to bump the version and update the pubspec too, right? |
In this case no, the existing version was OK. Anytime there is a trailing https://github.com/dart-lang/sdk/wiki/External-Package-Maintenance#making-a-change For future PRs it would also help to avoid a force push. We do a squash and merge once the PR is ready so we don't need to clean up into a single commit and force push ahead of time. https://github.com/dart-lang/sdk/wiki/External-Package-Maintenance#handling-pull-requests |
|
@natebosch We are a little pressed on time. Could you help us get this change published on pub and pulled into flutter/flutter? (we can do the latter) |
ghost
mentioned this pull request
|
I opened #85 Once that is approved I'll publish and update here. |
|
This is published as |
|
Thanks, Nate. I see 1.10.0-nullsafety.3 on pub, but I noticed it has an odd In the commit message you mentioned bumping the SDK version, but would it be possible to only bump the patch version so we can stay within currently stable SDK versions? The reason I'm asking is that |
|
You are trying to update the version pinned in the Flutter SDK? I would not have expected the SDK version to be a problem since they should be on In any case I tested this on earlier SDKs and can't find an incompatibility so I'll drop the min back down. |
Fix an issue where an async gap at the end of a stack trace would not get parsed correctly due to the trailing newline being `trim()`'d. Add tests to cover this case.
This fixes an issue where an async gap at the end of a stack trace would not get parsed correctly due to the trailing newline being
trim()'d.A couple of tests were added to cover this case.