This repository was archived by the owner on Nov 20, 2024. It is now read-only.
Fix examples in avoid_null_checks_in_equality_operators #3907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
linter-set-recommended
bwilkerson
approved these changes
Dec 14, 2022
| @override | ||
| operator ==(other) => other is Person && name == other.name; | ||
| operator ==(Object? other) => other is Person && name == other.name; |
Contributor
There was a problem hiding this comment.
Best practice is for the parameter to be Object because a null can't be passed in. (I haven't checked to see whether we have another warning for that.)
Contributor
Author
There was a problem hiding this comment.
Haha I know. But the lint won't fire under that practice.
pq
approved these changes
Dec 14, 2022
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few issues with the text, which I fix here:
operator ==; in Dart versions before null safety, this parameter type wasdynamic(I think), but after null safety, it isObject, so even aside from this lint rule, comparing to null wouldn't make sense.