This repository was archived by the owner on Nov 20, 2024. It is now read-only.
fix super.key false positive for use_key_in_widget_constructors
#3295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwilkerson
approved these changes
Mar 17, 2022
Contributor
bwilkerson
left a comment
bwilkerson
left a comment
There was a problem hiding this comment.
Looks fine as-is, just one random thought.
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 23, 2023
…rt-archive/linter#3295) * fix super.key false positive for `use_key_in_widget_constructors` * - type test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: flutter/flutter#100297.
(Note that we don't have Flutter mocked for our rule tests so I resorted to "old-school" testing.)
/cc @bwilkerson