Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/src/rules/avoid_types_as_parameter_names.dart
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,6 @@ class _Visitor extends SimpleAstVisitor<void> {

@override
void visitFormalParameterList(FormalParameterList node) {
if (node.parent is GenericFunctionType) return;

for (var parameter in node.parameters) {
var declaredElement = parameter.declaredElement;
var name = parameter.name;
Expand All @@ -87,7 +85,9 @@ class _Visitor extends SimpleAstVisitor<void> {
var result = context.resolveNameInScope(name.lexeme, false, scope);
if (result.isRequestedName) {
var element = result.element;
return element is ClassElement || element is TypeAliasElement;
return element is ClassElement ||
element is TypeAliasElement ||
element is TypeParameterElement;
}
return false;
}
Expand Down
12 changes: 11 additions & 1 deletion test_data/rules/avoid_types_as_parameter_names.dart
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,14 @@ m10(m1) => null; // OK
class FieldFormalParameter {
final int num;
FieldFormalParameter(this.num); // OK
}
}

void m11<X>(X) {} // LINT

void m12(int Function<T>(T) g) {} // OK

class C<X> {
C.name();
factory C(X) => C.name(); // LINT
void m(void Function(X) h) {} // OK
}