Refactor Apm class & integrate toolkit's ApmRepository class #352
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even thought this PR initially aimed with the objective of replacing the "Apm" class inside "src/utils/Apm.ts" file for dappnode's toolkit, as I was replacing it, I realised that this class was only used for resolving ENS names to addresses via it's ethereum Provider parameter, nothing specific to the Aragon Packet Manager.
The only Aragorn Packet Manager related methods are "encodeNewRepoWithVersionCall()" and "encodeNewVersionCall()" (which are not part of the Apm class itself, but are inside the same file).
So, in the end, this PR does the following:
Since CI is down atm, I ran all tests locally and passed.
TODO: We should consider adding "encodeNewRepoWithVersionCall()" and "encodeNewVersionCall()" to the dappnode toolkit, and then updating the SDK code again. Also, we should rename "src/utils/Apm.ts" file name, but kept it the same so reviewing this PR is easier