-
Notifications
You must be signed in to change notification settings - Fork 29
Open
Labels
P1Has to be done but not urgentHas to be done but not urgent
Description
The step saveAndCompressImagesCached is duplicated inside of both buildWithBuildx and buildWithCompose. Apparently is could be moved out and become a different Listr step
DAppNodeSDK/src/tasks/buildAndUpload.ts
Lines 215 to 220 in 525b49b
| title: `Build architecture ${architecture}`, | |
| task: () => | |
| new Listr( | |
| buildWithBuildx({ | |
| architecture, | |
| images, |
Then you wouldn't need to pipe arguments down through a function for no reson and de-duplicate
Metadata
Metadata
Assignees
Labels
P1Has to be done but not urgentHas to be done but not urgent