Upgrade to ethers 5 and use BigNumber instead of BN #545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roienatan
changed the title
dkent600
reviewed
Sep 19, 2020
| public approveTokens(tokenAddress: Address, spender: Address, amount: BN) { | ||
| const signer = (this.web3 as JsonRpcProvider).getSigner(this.defaultAccount as any) | ||
| public approveTokens(tokenAddress: Address, spender: Address, amount: BigNumber) { | ||
| const signer = (this.web3 as providers.JsonRpcProvider).getSigner(this.defaultAccount as any) |
There was a problem hiding this comment.
Why do you have to cast here? IF you have to cast, would it be better that it be to BaseProvider?
There was a problem hiding this comment.
Firstly I try to make the obvious changes to make arc.js work and the tests pass.
dkent600
reviewed
Sep 19, 2020
| export type Web3Provider = string | AsyncSendable | Signer | ||
| export type Web3Client = JsonRpcProvider | EthersWeb3JsProvider | ||
| export type Web3Provider = string | Signer // AsyncSendable | ||
| export type Web3Client = providers.JsonRpcProvider | providers.Web3Provider //| EthersWeb3JsProvider |
There was a problem hiding this comment.
would BaseProvider be easier here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #529 (ethers BigNumber instead of BN)
resolves: #501
Still many errors.
Migration reference: https://docs.ethers.io/v5/migration/