Fix #13825 (toomanyconfigs lacks file information) #7967
+47
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Looks like we are lacking tests for this (and |
Owner
Author
Yeah I was expecting some testfailures |
danmar
changed the title
firewave
reviewed
Nov 18, 2025
| f.write(f'#{dir} defined(X{i})\nx = {i};\n') | ||
| f.write('#endif\n') | ||
|
|
||
| args = ['--enable=information', '--template=daca2', str(test_file)] |
Collaborator
There was a problem hiding this comment.
Why are using the daca2 template?
Owner
Author
There was a problem hiding this comment.
because default template writes 3 lines instead of 1.
Owner
Author
There was a problem hiding this comment.
any 1-line template format will do here imho
firewave
reviewed
Nov 18, 2025
| // if maxConfigs has default value then report information message that configurations are skipped | ||
| if (mSettings.maxConfigs == 12 && mSettings.severity.isEnabled(Severity::information)) | ||
| tooManyConfigsError(Path::toNativeSeparators(file.spath()), configurations.size()); | ||
|
|
Collaborator
There was a problem hiding this comment.
This feels very strange.
Also the check for the default value should not be hard-coded - use a default Settings object to check against.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file-less warning generated from cppcheckexecutor.cpp is removed. the --errorlist message should match the real message.