Skip to content

Conversation

preenu91
Copy link

Improved help text for --enable=all flag: listed included checks, explained caution, added example usage.

@firewave
Copy link
Collaborator

Thanks for your contribution.

This does not feel like an improvement and rather just duplicates the documentation of the other options. And the example is unnecessary and invalid (whitespaces). What was you motivation to adjust this?

The existing wording about the whole program stuff is a bit vague and could be improved though.

@preenu91 preenu91 force-pushed the improve-enable-all-docs branch from bde1c3b to dcd6da9 Compare September 19, 2025 14:02
@preenu91
Copy link
Author

Thanks for the feedback! You’re right — my initial change ended up duplicating information that’s already documented elsewhere, and the example wasn’t necessary.

The main motivation was that the current wording about “whole program” felt vague. I’ve now revised the help text to focus only on clarifying that part, without duplicating other docs.

@preenu91 preenu91 force-pushed the improve-enable-all-docs branch from dcd6da9 to 91519a3 Compare September 19, 2025 14:11
@firewave
Copy link
Collaborator

The main motivation was that the current wording about “whole program” felt vague.

Agreed.

I’ve now revised the help text to focus only on clarifying that part, without duplicating other docs.

I think the all should be like "includes all the following" and leave any specifics to the respective entry.

We should also check what the actual manual/manpage says about this.

I think --help is conveying way too much information and should be very brief. Maybe within the planned CLI option help reworking we should introduce a way to get more details on an option via the CLI by allowing a single option together with --help similar to what other tools offer.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants