Skip to content

Conversation

firewave
Copy link
Collaborator

@firewave firewave commented Sep 18, 2025

@firewave firewave marked this pull request as draft September 18, 2025 12:43
@firewave firewave force-pushed the qt-wrap-ui branch 2 times, most recently from a38d9e1 to fca9982 Compare September 23, 2025 12:37
Copy link

@firewave firewave mentioned this pull request Sep 23, 2025
Copy link
Contributor

@pfultz2 pfultz2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No cmake changes until #7658 is merged first.

@firewave
Copy link
Collaborator Author

We did things wrong and doing it right somehow doesn't really work although it should. The Qt documentation is unfortunately not helpful on the surface because you are supposed to use helpers but those appear to mess with the global project state which is not what we want.

So cleaning that up first could help to find potential issues with your changes.

@pfultz2
Copy link
Contributor

pfultz2 commented Sep 26, 2025

We did things wrong and doing it right somehow doesn't really work although it should.

Sure, but #7658 doesn't change that.

So cleaning that up first could help to find potential issues with your changes.

#7658 works fine, you are just creating more work for me for no reason. Those changes should be merged in already, its been almost 3 months now. For now, we should hold off on any cmake changes until #7658 is merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants