Skip to content

moved TokenImpl out of global scope #7831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 27, 2025
Merged

moved TokenImpl out of global scope #7831

merged 3 commits into from
Sep 27, 2025
+146 −143

Conversation

firewave
Copy link
Collaborator

No description provided.

@firewave firewave mentioned this pull request Sep 17, 2025
Open
@firewave
Copy link
Collaborator Author

The first step in an attempt to make TokenImpl an actual implementation (i.e. not exposed).

@firewave firewave marked this pull request as draft September 17, 2025 09:36
@firewave firewave changed the title Token: do not rely on TokenImpl in interface moved TokenImpl out of global scope Sep 17, 2025
@firewave firewave marked this pull request as ready for review September 17, 2025 13:22
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@firewave firewave merged commit e5f0b8e into danmar:main Sep 27, 2025
53 checks passed
@firewave firewave deleted the tokenimpl branch September 27, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@firewave