Skip to content

Fix #14134 Hang in valueFlowSymbolic() caused by unrelated template #7814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2025
Merged

Fix #14134 Hang in valueFlowSymbolic() caused by unrelated template #7814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43adadd
Add test
chrchr-github Sep 11, 2025
794368c
Fix
chrchr-github Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/vf_analyzers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -838,6 +838,8 @@ static bool bifurcate(const Token* tok, const std::set<nonneg int>& varids, cons
const Variable* var = tok->variable();
if (!var)
return false;
if (!var->isLocal() && !var->isArgument())
return false;
const Token* start = var->declEndToken();
if (!start)
return false;
Expand Down
129 changes: 128 additions & 1 deletion test/cli/performance_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

# python -m pytest test-other.py
# python -m pytest performance_test.py

import os
import sys
Expand Down Expand Up @@ -240,3 +240,130 @@ def test_crash_array_in_namespace(tmpdir):
};
}""")
cppcheck([filename]) # should not take more than ~5 seconds

@pytest.mark.timeout(5)
def test_slow_bifurcate(tmpdir):
# #14134
filename = os.path.join(tmpdir, 'hang.cpp')
with open(filename, 'wt') as f:
f.write(r"""
class C {
public:
enum class Status {
Ok,
Waiting,
Error,
};
void setStatus(Status status, const QString& text);
QColor m_statusColor;
};

template < size_t N, typename T >
inline QDataStream& deserialize(QDataStream& in, T& value) {
if constexpr (N == 0) {}
else if constexpr (N == 1) {
auto& [f1] = value;
in >> f1;
}
else if constexpr (N == 2) {
auto& [f1, f2] = value;
in >> f1 >> f2;
}
else if constexpr (N == 3) {
auto& [f1, f2, f3] = value;
in >> f1 >> f2 >> f3;
}
else if constexpr (N == 4) {
auto& [f1, f2, f3, f4] = value;
in >> f1 >> f2 >> f3 >> f4;
}
else if constexpr (N == 5) {
auto& [f1, f2, f3, f4, f5] = value;
in >> f1 >> f2 >> f3 >> f4 >> f5;
}
else if constexpr (N == 6) {
auto& [f1, f2, f3, f4, f5, f6] = value;
in >> f1 >> f2 >> f3 >> f4 >> f5 >> f6;
}
else if constexpr (N == 7) {
auto& [f1, f2, f3, f4, f5, f6, f7] = value;
in >> f1 >> f2 >> f3 >> f4 >> f5 >> f6 >> f7;
}
else if constexpr (N == 8) {
auto& [f1, f2, f3, f4, f5, f6, f7, f8] = value;
in >> f1 >> f2 >> f3 >> f4 >> f5 >> f6 >> f7 >> f8;
}
else if constexpr (N == 9) {
auto& [f1, f2, f3, f4, f5, f6, f7, f8, f9] = value;
in >> f1 >> f2 >> f3 >> f4 >> f5 >> f6 >> f7 >> f8 >> f9;
}
else if constexpr (N == 10) {
auto& [f1, f2, f3, f4, f5, f6, f7, f8, f9, f10] = value;
in >> f1 >> f2 >> f3 >> f4 >> f5 >> f6 >> f7 >> f8 >> f9 >> f10;
}
else if constexpr (N == 11) {
auto& [f1, f2, f3, f4, f5, f6, f7, f8, f9, f10, f11] = value;
in >> f1 >> f2 >> f3 >> f4 >> f5 >> f6 >> f7 >> f8 >> f9 >> f10 >> f11;
}
else if constexpr (N == 12) {
auto& [f1, f2, f3, f4, f5, f6, f7, f8, f9, f10, f11, f12] = value;
in >> f1 >> f2 >> f3 >> f4 >> f5 >> f6 >> f7 >> f8 >> f9 >> f10 >> f11 >> f12;
}
else if constexpr (N == 13) {
auto& [f1, f2, f3, f4, f5, f6, f7, f8, f9, f10, f11, f12, f13] = value;
in >> f1 >> f2 >> f3 >> f4 >> f5 >> f6 >> f7 >> f8 >> f9 >> f10 >> f11 >> f12 >> f13;
}
else if constexpr (N == 14) {
auto& [f1, f2, f3, f4, f5, f6, f7, f8, f9, f10, f11, f12, f13, f14] = value;
in >> f1 >> f2 >> f3 >> f4 >> f5 >> f6 >> f7 >> f8 >> f9 >> f10 >> f11 >> f12 >> f13 >> f14;
}
else if constexpr (N == 15) {
auto& [f1, f2, f3, f4, f5, f6, f7, f8, f9, f10, f11, f12, f13, f14, f15] = value;
in >> f1 >> f2 >> f3 >> f4 >> f5 >> f6 >> f7 >> f8 >> f9 >> f10 >> f11 >> f12 >> f13 >> f14 >> f15;
}
else if constexpr (N == 16) {
auto& [f1, f2, f3, f4, f5, f6, f7, f8, f9, f10, f11, f12, f13, f14, f15, f16] = value;
in >> f1 >> f2 >> f3 >> f4 >> f5 >> f6 >> f7 >> f8 >> f9 >> f10 >> f11 >> f12 >> f13 >> f14 >> f15 >> f16;
}
else if constexpr (N == 17) {
auto& [f1, f2, f3, f4, f5, f6, f7, f8, f9, f10, f11, f12, f13, f14, f15, f16, f17] = value;
in >> f1 >> f2 >> f3 >> f4 >> f5 >> f6 >> f7 >> f8 >> f9 >> f10 >> f11 >> f12 >> f13 >> f14 >> f15 >> f16 >> f17;
}
else if constexpr (N == 18) {
auto& [f1, f2, f3, f4, f5, f6, f7, f8, f9, f10, f11, f12, f13, f14, f15, f16, f17, f18] = value;
in >> f1 >> f2 >> f3 >> f4 >> f5 >> f6 >> f7 >> f8 >> f9 >> f10 >> f11 >> f12 >> f13 >> f14 >> f15 >> f16 >> f17 >> f18;
}
else if constexpr (N == 19) {
auto& [f1, f2, f3, f4, f5, f6, f7, f8, f9, f10, f11, f12, f13, f14, f15, f16, f17, f18, f19] = value;
in >> f1 >> f2 >> f3 >> f4 >> f5 >> f6 >> f7 >> f8 >> f9 >> f10 >> f11 >> f12 >> f13 >> f14 >> f15 >> f16 >> f17 >> f18 >> f19;
}
else if constexpr (N == 20) {
auto& [f1, f2, f3, f4, f5, f6, f7, f8, f9, f10, f11, f12, f13, f14, f15, f16, f17, f18, f19, f20] = value;
in >> f1 >> f2 >> f3 >> f4 >> f5 >> f6 >> f7 >> f8 >> f9 >> f10 >> f11 >> f12 >> f13 >> f14 >> f15 >> f16 >> f17 >> f18 >> f19 >> f20;
}
else {
static_assert (!sizeof(T), "missing implementation");
}
return in;
}

void C::setStatus(Status status, const QString& text) {
const auto& colors = Config::get().ui().colors;
QColor color;
switch (status) {
case Status::Ok:
color = colors.green;
break;
case Status::Waiting:
color = Qt::black;
break;
case Status::Error:
color = colors.red;
break;
}

if (m_statusColor != color) {
m_statusColor = color;
}
}""")
cppcheck([filename]) # should not take more than ~1 second