fix #14077: fuzzing crash (assert) in Token::update_property_info()
#7808
Conversation
|
For fuzzing crashes please add the file attached to the ticket to the |
* allow member access on user defined literals * allow (tokens that look like) user defined literals in msvc asm blocks
|
| @@ -0,0 +1 @@ | |||
| _ 1p; No newline at end of file | |||
There was a problem hiding this comment.
this is garbage code and ideally I think we would throw a syntaxError. That might prevent further crashes if the fuzzer tries more such garbage..
I don't know .. a + name literal statement might be garbage always?
There was a problem hiding this comment.
Well the plus is just from the diff, and maybe the underscore could be an unknown macro? Either way i believe it should be a syntax error, afaik the suffix needs to begin with underscore, but maybe that should be its own ticket?
There was a problem hiding this comment.
Well the plus is just from the diff
ok understood.
Either way i believe it should be a syntax error, afaik the suffix needs to begin with underscore, but maybe that should be its own ticket?
as I understand it, user defined literals must start with underscore however library defined literals i.e. sv does not have to start with underscore.
There was a problem hiding this comment.
I reckon it is just invalid. It also happens with variables names that start with a number - see https://trac.cppcheck.net/ticket/14152.
No description provided.