Skip to content

Conversation

ludviggunne
Copy link
Collaborator

No description provided.

Copy link

sonarqubecloud bot commented Sep 7, 2025

@ludviggunne ludviggunne marked this pull request as draft September 8, 2025 09:44
@firewave
Copy link
Collaborator

firewave commented Sep 8, 2025

It is approved, so let's merge it and not add fixes for the other shortcomings to this.

We should merge #7800 and #7803 before fixing more as it might provide better feedback on the changes.

@firewave
Copy link
Collaborator

firewave commented Sep 8, 2025

It is approved, so let's merge it and not add fixes for the other shortcomings to this.

Having the fixes separate would also be better if we need to bisect things in case something went awry.

@ludviggunne
Copy link
Collaborator Author

Sure 👍

@ludviggunne ludviggunne marked this pull request as ready for review September 8, 2025 15:50
@firewave firewave merged commit 2c2342f into danmar:main Sep 8, 2025
63 checks passed
@ludviggunne ludviggunne deleted the 13714 branch September 8, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants