Switch back to require_relative #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently using `require` within a Puppet module can violate environment isolation, since the puppetserver might search in other environments (or possibly not search at all if it’s cached) for the relevant files. This doesn’t change files in spec/, since those aren’t used within the puppetserver process. Fixes #35
danielparks
force-pushed
the
require_relative
branch
from
e6178c9 to
b5f7ee0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently using
requirewithin a Puppet module can violate environment isolation, since the puppetserver might search in other environments (or possibly not search at all if it’s cached) for the relevant files.This doesn’t change file in spec, since those aren’t used within the puppetserver process.
Fixes #35