Skip to content

Fixed CSV format by using with double quotes commas. #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed CSV format by using with double quotes commas. #309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions datatables-core/src/main/java/com/github/dandelion/datatables/core/export/CsvExport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,18 @@
/**
* <p>
* CSV implementation of {@link DatatablesExport} that exports data in CSV
* format.
* format. Fields are surrounded by double quotes, embedded double quotes are
* escaped by doubling them, and fields are separated by commas.
* </p>
*
* @author Thibault Duchateau
* @author Arnaldo Piccinelli
*/
public class CsvExport implements DatatablesExport {

private static final String SEPARATOR_CHAR = ";";
private static final String SEPARATOR_CHAR = ",";
private static final String DOUBLE_QUOTES = "\"";
private static final String ESCAPED_DOUBLE_QUOTES = "\"\"";
private HtmlTable table;
private ExportConf exportConf;

Expand All @@ -57,23 +61,30 @@ public void initExport(HtmlTable table) {
this.exportConf = table.getTableConfiguration().getExportConfigurations().get(ReservedFormat.CSV);
}

private String escapeField(StringBuilder value) {
if (value == null) {
return "";
} else {
return value.toString().replaceAll(DOUBLE_QUOTES, ESCAPED_DOUBLE_QUOTES);
}
}

@Override
public void processExport(OutputStream output) {
StringBuilder buffer = new StringBuilder();

if (exportConf.getIncludeHeader()) {
for (HtmlRow row : table.getHeadRows()) {
for (HtmlColumn column : row.getColumns(ReservedFormat.ALL, ReservedFormat.CSV)) {
buffer.append(column.getContent()).append(SEPARATOR_CHAR);
buffer.append(DOUBLE_QUOTES).append(escapeField(column.getContent())).append(DOUBLE_QUOTES).append(SEPARATOR_CHAR);
}
buffer.append("\n");
}
}
for (HtmlRow row : table.getBodyRows()) {
for (HtmlColumn column : row.getColumns(ReservedFormat.ALL, ReservedFormat.CSV)) {
buffer.append(column.getContent()).append(SEPARATOR_CHAR);
buffer.append(DOUBLE_QUOTES).append(escapeField(column.getContent())).append(DOUBLE_QUOTES).append(SEPARATOR_CHAR);
}

buffer.append("\n");
}

Expand Down