chore: update cross origin command error #24891
Conversation
|
Thanks for taking the time to open a PR!
|
AtofStryker
requested review from
mjhenkes,
chrisbreiding,
emilyrohrbough and
jennifer-shehane
AtofStryker
changed the title
| \` <commands targeting ${autOrigin} go here>\` | ||
| \`})\` | ||
| `, | ||
| docsUrl: 'https://on.cypress.io/cy-visit-succeeded-but-commands-are-timing-out-because-you-visited-a-different-origin-domain-without-using-cy-origin', |
There was a problem hiding this comment.
whoa....this feels crazy verbose. Any way we could shorten?
https://on.cypress.io/visit-failed-wrong-origin',
There was a problem hiding this comment.
I think we can I just have no idea how these mappings are generated or linked. Thats just the header link in cypress-io/cypress-documentation#4880
There was a problem hiding this comment.
We need to create a on link in the services repo with the docs reference
There was a problem hiding this comment.
hows https://on.cypress.io/cy-visit-succeeded-but-commands-fail?
There was a problem hiding this comment.
got a link branch updated with the changes https://github.com/cypress-io/cypress-services/compare/chore/update-error-message-mapping?expand=1
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||||||
AtofStryker
force-pushed
the
chore/update-cross-origin-command-error
branch
from
082058e to
12d5ce1
Compare
|
on link PR update: https://github.com/cypress-io/cypress-services/pull/5040 |
User facing changelog
Additional details
Adds explainer to
cross_origin_commanderror to point users toError Messagesin v12 docs (Link needs to be added). see cypress-io/cypress-documentation#4880Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?