add html example to .not assertion #678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennifer-shehane
approved these changes
Jun 5, 2018
Merged
brian-mann
pushed a commit
that referenced
this pull request
Jun 7, 2018
* add new blogs w/img (#673) * add blog img img for e2e with Selenium and Cypress * add new blog e2e with Selenium and Cypress * add new blog testing react apps with cypress * add blog img testing react apps with cypress * add blog img start your end to end testing with angular and cypress * add new blog start end to end testing with angular and cypress * delete image with incorrect file extension * new blog img replaced image with .jpg file extension * rename file extension change .jgp to .jpg * Add PR template [skip ci] * add html example to .not assertion (#678) * update ci docs (#679) * chore(deps): Update sinon to 5.1.0 🌟 (#680) * chore(deps): update nock to 9.3.1 🌟 (#683) * add quotes around --spec arg (#686) * update ci docs
jennifer-shehane
added a commit
that referenced
this pull request
Jun 8, 2018
* add new blogs w/img (#673) * add blog img img for e2e with Selenium and Cypress * add new blog e2e with Selenium and Cypress * add new blog testing react apps with cypress * add blog img testing react apps with cypress * add blog img start your end to end testing with angular and cypress * add new blog start end to end testing with angular and cypress * delete image with incorrect file extension * new blog img replaced image with .jpg file extension * rename file extension change .jgp to .jpg * Add PR template [skip ci] * add html example to .not assertion (#678) * update ci docs (#679) * chore(deps): Update sinon to 5.1.0 🌟 (#680) * chore(deps): update nock to 9.3.1 🌟 (#683) * add quotes around --spec arg (#686) * update ci docs * chore(deps): update nock to 9.3.2 🌟 (#684)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used same html mark up from
filterdoc. Changed assertion to length instead of class, but how do you feel about that? I think it works. I wanted to useshouldandandbut it felt too lengthy.