Skip to content

Correct anchor links in FAQ Using Cypress #5682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

MikeMcC399
Copy link
Contributor

Issues

The target of the following links do not exist:

  • /guides/guides/web-security#Same-superdomain-per-test
  • /guides/core-concepts/introduction-to-cypress#Commands-Are-Not-Promises

Changes

In FAQ > Using Cypress the following links are changed:

Current Corrected
/guides/guides/web-security#Same-superdomain-per-test /guides/guides/web-security#Different-superdomain-per-test-requires-cyorigin-command
/guides/core-concepts/introduction-to-cypress#Commands-Are-Not-Promises /guides/core-concepts/introduction-to-cypress#The-Cypress-Command-Queue

The headings were previously changed by the following 2 PRs respectively:

  1. v12.0.0 Documentation #4853
  2. More clearly explain that cypress commands are not promises #4148

Copy link

netlify bot commented Feb 20, 2024

👷 Deploy request for cypress-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 010f01c

@cypress-app-bot
Copy link
Collaborator

Copy link

netlify bot commented Feb 20, 2024

Deploy Preview for benevolent-cat-040f48 ready!

Name Link
🔨 Latest commit 010f01c
🔍 Latest deploy log https://app.netlify.com/sites/benevolent-cat-040f48/deploys/65d49e7c186ad60008702d99
😎 Deploy Preview https://deploy-preview-5682--benevolent-cat-040f48.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review February 20, 2024 12:48
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@jennifer-shehane jennifer-shehane merged commit 0b19883 into cypress-io:main Feb 20, 2024
@MikeMcC399 MikeMcC399 deleted the links/faq-using branch February 20, 2024 15:17
@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

Thanks again!

You're welcome. The error list is now down to less than 70 lines and it's mostly the changelog now, which I will tackle in the coming days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants