-
Notifications
You must be signed in to change notification settings - Fork 1.1k
docs: add cypress-plugin-dotenv #5417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👷 Deploy request for cypress-docs pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for benevolent-cat-040f48 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Should I remove cypress-dotenv too? |
@MohamadKh75 You might like to cross-check against the plugins template. I couldn't see any CI pipeline on https://github.com/MohamadKh75/cypress-plugin-dotenv. Before submitting your plugin, please check to see if it fulfills these requirements:
If you have reason to believe your plugin does not need to meet certain requirements, please feel free to provide justification below: |
Hey @MikeMcC399 I have noted in README that there is an example. (cypress folder) |
@MohamadKh75 there are a couple of things that will help us get this added. As mentioned above, please use the plugin acceptance criteria. Seeing a passing CI pipeline is a great indicator of success and helps us with triaging contributions.
Also, for bonus points (and to answer your question), there is another cypress-dotenv plugin listed on the docs page. This was supporting pre v10 Cypress. It'd be a big help as part of this PR if you can place that near the bottom of the page in the "Legacy" section. Thanks! We look forward to your contribution. 💪 💪 |
I used GitHub actions to test and it's passing. |
Awesome @MohamadKh75 thanks for the extra legwork. We just released v13 today. Can we get your tests updated to run on the latest Cypress version? Then we should be good to merge 💪 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to get a passing test with Cypress v13, which was released today.
Done @jaffrepaul |
❤️