Skip to content

docs: add cypress-plugin-dotenv #5417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 5, 2023

Conversation

MoKhajavi75
Copy link

❤️

@netlify
Copy link

netlify bot commented Aug 12, 2023

👷 Deploy request for cypress-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit d3f3e70

@netlify
Copy link

netlify bot commented Aug 12, 2023

Deploy Preview for benevolent-cat-040f48 ready!

Name Link
🔨 Latest commit d3f3e70
🔍 Latest deploy log https://app.netlify.com/sites/benevolent-cat-040f48/deploys/64f73b7c7594260008c6d6ad
😎 Deploy Preview https://deploy-preview-5417--benevolent-cat-040f48.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress-app-bot
Copy link
Collaborator

@MoKhajavi75
Copy link
Author

Should I remove cypress-dotenv too?
It's not working with Cypress +10

@MikeMcC399
Copy link
Contributor

@MohamadKh75

You might like to cross-check against the plugins template. I couldn't see any CI pipeline on https://github.com/MohamadKh75/cypress-plugin-dotenv.

Before submitting your plugin, please check to see if it fulfills these requirements:

  • 🚀 Works with the latest major version of Cypress
  • 🛠 Plugin purpose is clearly documented (in a README or docs website)
  • 📝 Well-written documentation - A great example (link)
  • 🔬 Tested using Cypress - tests using Cypress can act as both example usage and test coverage
  • 👷‍♀️ CI pipeline that's passing (CircleCI and Github Actions are both free for Open Source)

If you have reason to believe your plugin does not need to meet certain requirements, please feel free to provide justification below:

@MoKhajavi75
Copy link
Author

Hey @MikeMcC399

I have noted in README that there is an example. (cypress folder)
I check, and it's working with the latest version of Cypress.
It's a very simple plugin, and README contains enough docs and information.

@jaffrepaul
Copy link
Contributor

@MohamadKh75 there are a couple of things that will help us get this added. As mentioned above, please use the plugin acceptance criteria. Seeing a passing CI pipeline is a great indicator of success and helps us with triaging contributions.

Before submitting your plugin, please check to see if it fulfills these requirements:

  • 🚀 Works with the latest major version of Cypress
  • 🛠 Plugin purpose is clearly documented (in a README or docs website)
  • 📝 Well-written documentation - A great example (link)
  • 🔬 Tested using Cypress - tests using Cypress can act as both example usage and test coverage
  • 👷‍♀️ CI pipeline that's passing (CircleCI and Github Actions are both free for Open Source)

If you have reason to believe your plugin does not need to meet certain requirements, please feel free to provide justification below:

Also, for bonus points (and to answer your question), there is another cypress-dotenv plugin listed on the docs page. This was supporting pre v10 Cypress. It'd be a big help as part of this PR if you can place that near the bottom of the page in the "Legacy" section.

Thanks! We look forward to your contribution.

💪 💪

@MoKhajavi75
Copy link
Author

I used GitHub actions to test and it's passing.
Also, I moved the other plugin to the legacy section.

@MikeMcC399 @jaffrepaul

@jaffrepaul
Copy link
Contributor

Awesome @MohamadKh75 thanks for the extra legwork. We just released v13 today. Can we get your tests updated to run on the latest Cypress version? Then we should be good to merge 💪

Copy link
Contributor

@jaffrepaul jaffrepaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to get a passing test with Cypress v13, which was released today.

@MoKhajavi75
Copy link
Author

Done @jaffrepaul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants